From: Daniel Borkmann <daniel@iogearbox.net>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>
Cc: bpf@vger.kernel.org, Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Sumanth Korikkar <sumanthk@linux.ibm.com>
Subject: Re: [PATCH bpf 0/2] Two fixes for make kselftest TARGETS=bpf
Date: Tue, 2 Jun 2020 22:37:44 +0200 [thread overview]
Message-ID: <fd33d451-c570-96b2-6e5d-c9945f0e465d@iogearbox.net> (raw)
In-Reply-To: <20200602175649.2501580-1-iii@linux.ibm.com>
On 6/2/20 7:56 PM, Ilya Leoshkevich wrote:
> While the primary documented way to run BPF tests is by invoking
> make in tools/testing/selftests/bpf, kselftest documentation implies that
> make kselftest TARGETS=bpf from the top directory should work as well.
> This patch series contains two fixes that were neccesary to make it run:
>
> - Patch 1: $(COMPILE.c) -> $(CC) $(CFLAGS) -c
> - Patch 2: Add CXX=$(CROSS_COMPILE)g++ default value
>
> Ilya Leoshkevich (2):
> tools/bpf: Don't use $(COMPILE.c)
> selftests/bpf: Add a default $(CXX) value
>
> tools/bpf/Makefile | 6 +++---
> tools/bpf/bpftool/Makefile | 8 ++++----
> tools/testing/selftests/bpf/Makefile | 1 +
> 3 files changed, 8 insertions(+), 7 deletions(-)
I've tested on x86-64 and arm64 as well, applied, thanks!
prev parent reply other threads:[~2020-06-02 20:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 17:56 [PATCH bpf 0/2] Two fixes for make kselftest TARGETS=bpf Ilya Leoshkevich
2020-06-02 17:56 ` [PATCH bpf 1/2] tools/bpf: Don't use $(COMPILE.c) Ilya Leoshkevich
2020-06-02 17:56 ` [PATCH bpf 2/2] selftests/bpf: Add a default $(CXX) value Ilya Leoshkevich
2020-06-02 20:37 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd33d451-c570-96b2-6e5d-c9945f0e465d@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=iii@linux.ibm.com \
--cc=sumanthk@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).