From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E5A0C433DF for ; Wed, 27 May 2020 17:02:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFDFF2071A for ; Wed, 27 May 2020 17:02:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P2lEaBvc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730949AbgE0RCw (ORCPT ); Wed, 27 May 2020 13:02:52 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:31404 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728883AbgE0RCw (ORCPT ); Wed, 27 May 2020 13:02:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590598971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0llQvuHUDajWbd807ZLZZoLe6sIkfmzt8DCvGnqKX3w=; b=P2lEaBvcehtQOLZ74Xy8FD33FrJSmXWzhWxDESFJjhZeWdhOnghpH6LUz9TsfC8GbtV8Tl 9ztcgtRM40F2BNQK/gUfcCHSSNJY4RTkijBAzoXog2UTRU4RQW9sVuSeXaqxusvNIzsbqc DUP3dfES9wy+2upB9C0yQqN1O/NFsaw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-96-1Xhp6ZlVNRWCfah0MzcNvA-1; Wed, 27 May 2020 13:02:49 -0400 X-MC-Unique: 1Xhp6ZlVNRWCfah0MzcNvA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2A786835B47; Wed, 27 May 2020 17:02:48 +0000 (UTC) Received: from astarta.redhat.com (ovpn-114-49.ams2.redhat.com [10.36.114.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B8401768A0; Wed, 27 May 2020 17:02:43 +0000 (UTC) From: Yauheni Kaliuta To: Alexei Starovoitov Cc: Andrii Nakryiko , bpf , Jiri Benc , Jiri Olsa , Andrii Nakryiko , Daniel Borkmann , linux-kselftest@vger.kernel.org Subject: Re: [PATCH] selftests/bpf: split -extras target to -static and -gen References: <20200522081901.238516-1-yauheni.kaliuta@redhat.com> Date: Wed, 27 May 2020 20:02:41 +0300 In-Reply-To: (Alexei Starovoitov's message of "Wed, 27 May 2020 09:48:04 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hi, Alexei! >>>>> On Wed, 27 May 2020 09:48:04 -0700, Alexei Starovoitov wrote: > On Wed, May 27, 2020 at 12:19 AM Yauheni Kaliuta > wrote: >> >> Hi, Alexei! >> >> >>>>> On Tue, 26 May 2020 22:37:39 -0700, Alexei Starovoitov wrote: >> >> > On Tue, May 26, 2020 at 10:31 PM Yauheni Kaliuta >> > wrote: >> >> >> >> Hi, Andrii! >> >> >> >> >>>>> On Tue, 26 May 2020 17:19:18 -0700, Andrii Nakryiko wrote: >> >> >> >> > On Fri, May 22, 2020 at 1:19 AM Yauheni Kaliuta >> >> > wrote: >> >> >> >> >> >> There is difference in depoying static and generated extra resource >> >> >> files between in/out of tree build and flavors: >> >> >> >> >> >> - in case of unflavored out-of-tree build static files are not >> >> >> available and must be copied as well as both static and generated >> >> >> files for flavored build. >> >> >> >> >> >> So split the rules and variables. The name TRUNNER_EXTRA_GEN_FILES >> >> >> is chosen in analogy to TEST_GEN_* variants. >> >> >> >> >> >> >> > Can we keep them together but be smarter about what needs to >> >> > be copied based on source/target directories? I would really >> >> > like to not blow up all these rules. >> >> >> >> I can try, ok, I just find it a bit more clear. But it's good to >> >> get some input from kselftest about OOT build in general. >> >> > I see no value in 'make install' of selftests/bpf >> > and since it's broken just remove that makefile target. >> >> Some CI systems perform testing next stage after building were >> build tree is not available anymore. So it's in use at the >> moment. > such CI systems can do 'cp -r' then It's a discussion for linux-kselftest@ (added). At the moment `make install` is generic kselftest functionality and since bpf is part of that infra it looks a bit strange to break it intentionally. -- WBR, Yauheni Kaliuta