From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, Jiri Benc <jbenc@redhat.com>,
Jiri Olsa <jolsa@redhat.com>, Andrii Nakryiko <andriin@fb.com>
Subject: Re: [PATCH 0/8] selftests/bpf: installation and out of tree build fixes
Date: Wed, 27 May 2020 07:45:37 +0300 [thread overview]
Message-ID: <xunyzh9uouj2.fsf@redhat.com> (raw)
In-Reply-To: <77645d8b-2448-a35b-912a-abd3e329139d@iogearbox.net> (Daniel Borkmann's message of "Tue, 26 May 2020 23:48:01 +0200")
Hi, Daniel!
>>>>> On Tue, 26 May 2020 23:48:01 +0200, Daniel Borkmann wrote:
> On 5/22/20 8:40 AM, Yauheni Kaliuta wrote:
>>
>> Actually, a bit more needed :)
> Not quite sure how to parse this, I presume you are intending
> to send a v2 of this series with [0] folded in? Please also do
> not add line-breaks in the middle of all your Fixes tags as
> otherwise it would break searching for commits in the git
> log. For the v2 respin, please also add a better cover letter
> than just saying nothing more than 'I had a look, here are
> some fixes.'. At least a minimal high level summary of the
> selftest Makefile changes in this series.
Thanks! That was part of thread with Andrii, but I should have
sent separated. Anyway (see Andrii's comments) it's not coming as
is, so I'll do v2. Sorry for that.
> Thanks,
> Daniel
> [0]
> https://patchwork.ozlabs.org/project/netdev/patch/20200522081901.238516-1-yauheni.kaliuta@redhat.com/
>>>>>>> On Fri, 22 May 2020 07:13:02 +0300, Yauheni Kaliuta wrote:
>>
>> > I had a look, here are some fixes.
>> > Yauheni Kaliuta (8):
>> > selftests/bpf: remove test_align from Makefile
>> > selftests/bpf: build bench.o for any $(OUTPUT)
>> > selftests/bpf: install btf .c files
>> > selftests/bpf: fix object files installation
>> > selftests/bpf: add output dir to include list
>> > selftests/bpf: fix urandom_read installation
>> > selftests/bpf: fix test.h placing for out of tree build
>> > selftests/bpf: factor out MKDIR rule
>>
>> > tools/testing/selftests/bpf/Makefile | 77 ++++++++++++++++++++--------
>> > 1 file changed, 55 insertions(+), 22 deletions(-)
>>
>> > --
>> > 2.26.2
>>
>>
--
WBR,
Yauheni Kaliuta
next prev parent reply other threads:[~2020-05-27 4:45 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 4:13 [PATCH 0/8] selftests/bpf: installation and out of tree build fixes Yauheni Kaliuta
2020-05-22 4:13 ` [PATCH 1/8] selftests/bpf: remove test_align from Makefile Yauheni Kaliuta
2020-05-26 22:13 ` Andrii Nakryiko
2020-05-22 4:13 ` [PATCH 2/8] selftests/bpf: build bench.o for any $(OUTPUT) Yauheni Kaliuta
2020-05-26 22:13 ` Andrii Nakryiko
2020-05-27 4:54 ` Yauheni Kaliuta
2020-05-22 4:13 ` [PATCH 3/8] selftests/bpf: install btf .c files Yauheni Kaliuta
2020-05-22 4:13 ` [PATCH 4/8] selftests/bpf: fix object files installation Yauheni Kaliuta
2020-05-26 22:30 ` Andrii Nakryiko
2020-05-27 5:17 ` Yauheni Kaliuta
2020-05-28 18:39 ` Andrii Nakryiko
2020-05-28 18:46 ` Yauheni Kaliuta
2020-05-22 4:13 ` [PATCH 5/8] selftests/bpf: add output dir to include list Yauheni Kaliuta
2020-05-26 22:13 ` Andrii Nakryiko
2020-05-22 4:13 ` [PATCH 6/8] selftests/bpf: fix urandom_read installation Yauheni Kaliuta
2020-05-26 22:13 ` Andrii Nakryiko
2020-05-22 4:13 ` [PATCH 7/8] selftests/bpf: fix test.h placing for out of tree build Yauheni Kaliuta
2020-05-26 22:26 ` Andrii Nakryiko
2020-05-27 5:06 ` Yauheni Kaliuta
2020-05-22 4:13 ` [PATCH 8/8] selftests/bpf: factor out MKDIR rule Yauheni Kaliuta
2020-05-26 22:29 ` Andrii Nakryiko
2020-05-27 5:07 ` Yauheni Kaliuta
2020-05-22 6:40 ` [PATCH 0/8] selftests/bpf: installation and out of tree build fixes Yauheni Kaliuta
2020-05-22 8:19 ` [PATCH] selftests/bpf: split -extras target to -static and -gen Yauheni Kaliuta
2020-05-27 0:19 ` Andrii Nakryiko
2020-05-27 5:21 ` Yauheni Kaliuta
2020-05-27 5:37 ` Alexei Starovoitov
2020-05-27 7:19 ` Yauheni Kaliuta
2020-05-27 16:48 ` Alexei Starovoitov
2020-05-27 17:02 ` Yauheni Kaliuta
2020-05-27 17:05 ` Alexei Starovoitov
2020-05-27 22:01 ` shuah
2020-05-27 22:23 ` Alexei Starovoitov
2020-05-28 8:05 ` Jiri Benc
2020-05-28 10:56 ` Greg KH
2020-05-28 16:14 ` Alexei Starovoitov
2020-05-28 17:07 ` Shuah Khan
2020-05-28 18:15 ` Alexei Starovoitov
2020-05-28 18:29 ` Yauheni Kaliuta
2020-05-28 18:34 ` Alexei Starovoitov
2020-05-28 19:05 ` Shuah Khan
2020-05-28 18:59 ` Shuah Khan
2020-05-28 19:18 ` Alexei Starovoitov
2020-05-28 20:09 ` Shuah Khan
2020-05-28 22:47 ` Shuah Khan
2020-05-28 17:10 ` Yauheni Kaliuta
2020-05-28 18:17 ` Alexei Starovoitov
2020-05-28 19:09 ` Shuah Khan
2020-05-28 19:20 ` Yauheni Kaliuta
2020-05-28 19:34 ` Shuah Khan
2020-05-26 21:48 ` [PATCH 0/8] selftests/bpf: installation and out of tree build fixes Daniel Borkmann
2020-05-27 4:45 ` Yauheni Kaliuta [this message]
2020-05-26 22:32 ` Andrii Nakryiko
2020-05-27 4:52 ` Yauheni Kaliuta
2020-05-27 5:04 ` Andrii Nakryiko
2020-05-27 7:25 ` Yauheni Kaliuta
2020-05-27 8:05 ` Yauheni Kaliuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xunyzh9uouj2.fsf@redhat.com \
--to=yauheni.kaliuta@redhat.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jbenc@redhat.com \
--cc=jolsa@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).