All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Kucheria <amit.kucheria@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, viresh.kumar@linaro.org,
	edubezval@gmail.com, swboyd@chromium.org, dianders@chromium.org,
	mka@chromium.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-pm@vger.kernel.org
Subject: [PATCH v4 5/9] cpufreq: cpufreq-dt: Use auto-registration of thermal cooling device
Date: Mon, 28 Jan 2019 12:11:30 +0530	[thread overview]
Message-ID: <cb7296e38ec506b008e65ecf5f80ccb356f67fb8.1548654899.git.amit.kucheria@linaro.org> (raw)
In-Reply-To: <cover.1548654899.git.amit.kucheria@linaro.org>
In-Reply-To: <cover.1548654899.git.amit.kucheria@linaro.org>

Use the CPUFREQ_AUTO_REGISTER_COOLING_DEV flag to allow cpufreq core to
automatically register as a thermal cooling device.

This allows removal of boiler plate code from the driver.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 drivers/cpufreq/cpufreq-dt.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
index e58bfcb1169e..2a4c4ea7980b 100644
--- a/drivers/cpufreq/cpufreq-dt.c
+++ b/drivers/cpufreq/cpufreq-dt.c
@@ -13,7 +13,6 @@
 
 #include <linux/clk.h>
 #include <linux/cpu.h>
-#include <linux/cpu_cooling.h>
 #include <linux/cpufreq.h>
 #include <linux/cpumask.h>
 #include <linux/err.h>
@@ -30,7 +29,6 @@
 struct private_data {
 	struct opp_table *opp_table;
 	struct device *cpu_dev;
-	struct thermal_cooling_device *cdev;
 	const char *reg_name;
 	bool have_static_opps;
 };
@@ -301,7 +299,6 @@ static int cpufreq_exit(struct cpufreq_policy *policy)
 {
 	struct private_data *priv = policy->driver_data;
 
-	cpufreq_cooling_unregister(priv->cdev);
 	dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table);
 	if (priv->have_static_opps)
 		dev_pm_opp_of_cpumask_remove_table(policy->related_cpus);
@@ -314,21 +311,14 @@ static int cpufreq_exit(struct cpufreq_policy *policy)
 	return 0;
 }
 
-static void cpufreq_ready(struct cpufreq_policy *policy)
-{
-	struct private_data *priv = policy->driver_data;
-
-	priv->cdev = of_cpufreq_cooling_register(policy);
-}
-
 static struct cpufreq_driver dt_cpufreq_driver = {
-	.flags = CPUFREQ_STICKY | CPUFREQ_NEED_INITIAL_FREQ_CHECK,
+	.flags = CPUFREQ_STICKY | CPUFREQ_NEED_INITIAL_FREQ_CHECK |
+		 CPUFREQ_AUTO_REGISTER_COOLING_DEV,
 	.verify = cpufreq_generic_frequency_table_verify,
 	.target_index = set_target,
 	.get = cpufreq_generic_get,
 	.init = cpufreq_init,
 	.exit = cpufreq_exit,
-	.ready = cpufreq_ready,
 	.name = "cpufreq-dt",
 	.attr = cpufreq_dt_attr,
 	.suspend = cpufreq_generic_suspend,
-- 
2.17.1

  parent reply	other threads:[~2019-01-28  6:41 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28  6:41 [PATCH v4 0/9] cpufreq: Add flag to auto-register as cooling device Amit Kucheria
2019-01-28  6:41 ` Amit Kucheria
2019-01-28  6:41 ` Amit Kucheria
2019-01-28  6:41 ` [PATCH v4 1/9] thermal: cpu_cooling: Require thermal core to be compiled in Amit Kucheria
2019-01-28  6:41 ` [PATCH v4 2/9] cpufreq: Auto-register the driver as a thermal cooling device if asked Amit Kucheria
2019-01-28  8:29   ` Daniel Lezcano
2019-01-28  8:32   ` Daniel Lezcano
2019-01-28 12:03     ` Rafael J. Wysocki
2019-01-29  4:21       ` Amit Kucheria
2019-01-28  9:03   ` Rafael J. Wysocki
2019-01-28  6:41 ` [PATCH v4 3/9] cpufreq: qcom-hw: Register as a cpufreq cooling device Amit Kucheria
2019-01-28  8:32   ` Daniel Lezcano
2019-01-28  6:41 ` [PATCH v4 4/9] cpufreq: imx6q: Use auto-registration of thermal " Amit Kucheria
2019-01-28  8:34   ` Daniel Lezcano
2019-01-28  6:41 ` Amit Kucheria [this message]
2019-01-28  8:35   ` [PATCH v4 5/9] cpufreq: cpufreq-dt: " Daniel Lezcano
2019-01-28  6:41 ` [PATCH v4 6/9] cpufreq: mediatek: " Amit Kucheria
2019-01-28  6:41   ` Amit Kucheria
2019-01-28  8:36   ` Daniel Lezcano
2019-01-28  8:36     ` Daniel Lezcano
2019-01-28  6:41 ` [PATCH v4 7/9] cpufreq: qoriq: " Amit Kucheria
2019-01-28  8:37   ` Daniel Lezcano
2019-01-28  6:41 ` [PATCH v4 8/9] cpufreq: scmi: " Amit Kucheria
2019-01-28  6:41   ` Amit Kucheria
2019-01-28  8:39   ` Daniel Lezcano
2019-01-28  8:39     ` Daniel Lezcano
2019-01-28  6:41 ` [PATCH v4 9/9] cpufreq: scpi: " Amit Kucheria
2019-01-28  6:41   ` Amit Kucheria
2019-01-28  8:40   ` Daniel Lezcano
2019-01-28  8:40     ` Daniel Lezcano
2019-01-28  6:47 ` [PATCH v4 0/9] cpufreq: Add flag to auto-register as " Viresh Kumar
2019-01-28  6:47   ` Viresh Kumar
2019-01-28  6:47   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb7296e38ec506b008e65ecf5f80ccb356f67fb8.1548654899.git.amit.kucheria@linaro.org \
    --to=amit.kucheria@linaro.org \
    --cc=dianders@chromium.org \
    --cc=edubezval@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=rjw@rjwysocki.net \
    --cc=swboyd@chromium.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.