From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B900C433C1 for ; Fri, 26 Mar 2021 15:41:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 546BB61A1E for ; Fri, 26 Mar 2021 15:41:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230104AbhCZPkr (ORCPT ); Fri, 26 Mar 2021 11:40:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:54968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbhCZPkg (ORCPT ); Fri, 26 Mar 2021 11:40:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5C26161A1E; Fri, 26 Mar 2021 15:40:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616773235; bh=5QHjsOuCeKmAcwCLCBPIamZAmQzcQhQ5LSmlww771UM=; h=From:To:Cc:Subject:Date:From; b=G+jzmFkDBl+LqfD6jWAehGh81aF5345grfOBofHH7GkAYFLoFlGZuaiS9DdkwGJ5w WUq6ntB9atJ+bPf1g9mDxC5K+iiTU/pyXzVDCsCLYzOI49GDIzXTjkexevFZNde+BH RwZzTf1z+jyFYNEGKKNyGsvnCQvLfA3lFPAO89mHPNUQFTXjqclUyjK8RuRIq6jkX5 qX5JaulJlHacuyH58CwYFvBZcuzbEEqVQID67zpKdUYCMXzCEbeOuYRXG47DrQVil6 DOZetSMLbA3sJZ7expQFcyTV/Wpyo/hAL+PZu0t1J1XRr528TtuwXa0ShwVHfKdt2c BiC1luyBH8MUg== From: Jeff Layton To: ceph-devel@vger.kernel.org Cc: idryomov@gmail.com, Luis Henriques Subject: [PATCH] ceph: fix inode leak on getattr error in __fh_to_dentry Date: Fri, 26 Mar 2021 11:40:32 -0400 Message-Id: <20210326154032.86410-1-jlayton@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org Cc: Luis Henriques Fixes: 878dabb64117 (ceph: don't return -ESTALE if there's still an open file) Signed-off-by: Jeff Layton --- fs/ceph/export.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ceph/export.c b/fs/ceph/export.c index f22156ee7306..17d8c8f4ec89 100644 --- a/fs/ceph/export.c +++ b/fs/ceph/export.c @@ -178,8 +178,10 @@ static struct dentry *__fh_to_dentry(struct super_block *sb, u64 ino) return ERR_CAST(inode); /* We need LINK caps to reliably check i_nlink */ err = ceph_do_getattr(inode, CEPH_CAP_LINK_SHARED, false); - if (err) + if (err) { + iput(inode); return ERR_PTR(err); + } /* -ESTALE if inode as been unlinked and no file is open */ if ((inode->i_nlink == 0) && (atomic_read(&inode->i_count) == 1)) { iput(inode); -- 2.30.2