ceph-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Venky Shankar <vshankar@redhat.com>
To: jlayton@redhat.com, idryomov@gmail.com, lhenriques@suse.de
Cc: pdonnell@redhat.com, ceph-devel@vger.kernel.org,
	Venky Shankar <vshankar@redhat.com>
Subject: [PATCH v2 0/4] ceph: new mount device syntax
Date: Fri,  2 Jul 2021 12:18:17 +0530	[thread overview]
Message-ID: <20210702064821.148063-1-vshankar@redhat.com> (raw)

v2:
 - doc suggestions/fixes by Jeff
 - parse_fsid -> ceph_parse_fsid
 - avoid kstrdup whereever possible, also fixes a memleak
 - fail mount when mon_addr is unavailable (for new syntax)
 - use dout() instead of invalfc() during new syntax check

This series introduces changes Ceph File System mount device string.
Old mount device syntax (source) has the following problems:

mounts to the same cluster but with different fsnames
and/or creds have identical device string which can
confuse xfstests.

Userspace mount helper tool resolves monitor addresses
and fill in mon addrs automatically, but that means the
device shown in /proc/mounts is different than what was
used for mounting.

New device syntax is as follows:

  cephuser@fsid.mycephfs2=/path

Note, there is no "monitor address" in the device string.
That gets passed in as mount option. This keeps the device
string same when monitor addresses change (on remounts).

Also note that the userspace mount helper tool is backward
compatible. I.e., the mount helper will fallback to using
old syntax after trying to mount with the new syntax.

Venky Shankar (4):
  ceph: new device mount syntax
  ceph: validate cluster FSID for new device syntax
  ceph: record updated mon_addr on remount
  doc: document new CephFS mount device syntax

 Documentation/filesystems/ceph.rst |  25 +++++-
 fs/ceph/super.c                    | 137 ++++++++++++++++++++++++++---
 fs/ceph/super.h                    |   4 +
 include/linux/ceph/libceph.h       |   1 +
 net/ceph/ceph_common.c             |   5 +-
 5 files changed, 157 insertions(+), 15 deletions(-)

-- 
2.27.0


             reply	other threads:[~2021-07-02  6:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02  6:48 Venky Shankar [this message]
2021-07-02  6:48 ` [PATCH v2 1/4] ceph: new device mount syntax Venky Shankar
2021-07-02 10:38   ` Luis Henriques
2021-07-02 11:05     ` Venky Shankar
2021-07-06 18:41       ` Jeff Layton
2021-07-02  6:48 ` [PATCH v2 2/4] ceph: validate cluster FSID for new device syntax Venky Shankar
2021-07-02 10:44   ` Luis Henriques
2021-07-02 10:48     ` Luis Henriques
2021-07-02 11:10     ` Venky Shankar
2021-07-02 13:49       ` Luis Henriques
2021-07-02 14:57         ` Venky Shankar
2021-07-06 18:35           ` Jeff Layton
2021-07-07  5:05             ` Venky Shankar
2021-07-02  6:48 ` [PATCH v2 3/4] ceph: record updated mon_addr on remount Venky Shankar
2021-07-02  6:48 ` [PATCH v2 4/4] doc: document new CephFS mount device syntax Venky Shankar
2021-07-02 18:08   ` Patrick Donnelly
2021-07-05  4:39     ` Venky Shankar
2021-07-06 18:25       ` Jeff Layton
2021-07-02 18:05 ` [PATCH v2 0/4] ceph: new " Patrick Donnelly
2021-07-05  4:36   ` Venky Shankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210702064821.148063-1-vshankar@redhat.com \
    --to=vshankar@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=jlayton@redhat.com \
    --cc=lhenriques@suse.de \
    --cc=pdonnell@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).