From: Luis Henriques <lhenriques@suse.de>
To: Jeff Layton <jlayton@kernel.org>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH] ceph: enable async dirops by default
Date: Wed, 20 Jan 2021 11:07:57 +0000 [thread overview]
Message-ID: <87o8hjoohe.fsf@suse.de> (raw)
In-Reply-To: <20210119144430.337370-1-jlayton@kernel.org> (Jeff Layton's message of "Tue, 19 Jan 2021 09:44:30 -0500")
Jeff Layton <jlayton@kernel.org> writes:
> This has been behaving reasonably well in testing, and enabling this
> offers significant performance benefits. Enable async dirops by default
> in the kclient going forward, and change show_options to add "wsync"
> when they are disabled.
Sounds good! Maybe it's worth adding this option to the mount options
listed in Documentation/filesystems/ceph.rst (although it's quite possible
that other mount options are already missing there).
Cheers,
--
Luis
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> fs/ceph/super.c | 4 ++--
> fs/ceph/super.h | 5 +++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ceph/super.c b/fs/ceph/super.c
> index 9b1b7f4cfdd4..884e2ffabfaf 100644
> --- a/fs/ceph/super.c
> +++ b/fs/ceph/super.c
> @@ -577,8 +577,8 @@ static int ceph_show_options(struct seq_file *m, struct dentry *root)
> if (fsopt->flags & CEPH_MOUNT_OPT_CLEANRECOVER)
> seq_show_option(m, "recover_session", "clean");
>
> - if (fsopt->flags & CEPH_MOUNT_OPT_ASYNC_DIROPS)
> - seq_puts(m, ",nowsync");
> + if (!(fsopt->flags & CEPH_MOUNT_OPT_ASYNC_DIROPS))
> + seq_puts(m, ",wsync");
>
> if (fsopt->wsize != CEPH_MAX_WRITE_SIZE)
> seq_printf(m, ",wsize=%u", fsopt->wsize);
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index 13b02887b085..8ee2745f6257 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -46,8 +46,9 @@
> #define CEPH_MOUNT_OPT_ASYNC_DIROPS (1<<15) /* allow async directory ops */
>
> #define CEPH_MOUNT_OPT_DEFAULT \
> - (CEPH_MOUNT_OPT_DCACHE | \
> - CEPH_MOUNT_OPT_NOCOPYFROM)
> + (CEPH_MOUNT_OPT_DCACHE | \
> + CEPH_MOUNT_OPT_NOCOPYFROM | \
> + CEPH_MOUNT_OPT_ASYNC_DIROPS)
>
> #define ceph_set_mount_opt(fsc, opt) \
> (fsc)->mount_options->flags |= CEPH_MOUNT_OPT_##opt
> --
>
> 2.29.2
>
next prev parent reply other threads:[~2021-01-20 12:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 14:44 [PATCH] ceph: enable async dirops by default Jeff Layton
2021-01-20 10:46 ` Ilya Dryomov
2021-01-20 12:00 ` Jeff Layton
2021-01-20 12:24 ` Ilya Dryomov
2021-02-17 2:41 ` Patrick Donnelly
2021-01-20 11:07 ` Luis Henriques [this message]
2021-08-09 16:44 Jeff Layton
2021-09-01 16:54 ` Jeff Layton
2021-09-02 15:52 ` Ilya Dryomov
2021-09-07 21:07 ` Patrick Donnelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8hjoohe.fsf@suse.de \
--to=lhenriques@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=jlayton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).