From: Venky Shankar <vshankar@redhat.com>
To: Patrick Donnelly <pdonnell@redhat.com>
Cc: Jeff Layton <jlayton@redhat.com>,
Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [RFC 2/2] ceph: add debugfs entries for v2 (new) mount syntax support
Date: Mon, 23 Aug 2021 10:15:51 +0530 [thread overview]
Message-ID: <CACPzV1mPkwRmC-dA7oWNQ3=RsDPfw=tMJgw8sX_-CARy1UWH9w@mail.gmail.com> (raw)
In-Reply-To: <CA+2bHPbs0EvoVjJazb1mLpZfX0euNratkhfzkWwP=_gHQAEvOQ@mail.gmail.com>
On Sat, Aug 21, 2021 at 7:23 AM Patrick Donnelly <pdonnell@redhat.com> wrote:
>
> On Wed, Aug 18, 2021 at 2:01 AM Venky Shankar <vshankar@redhat.com> wrote:
> >
> > [...]
>
> Is "debugfs" the right place for this? I do wonder if that can be
> dropped/disabled via some obscure kernel config?
The primary use for this (v2 syntax entry) is for catching bugs in v2
mount syntax implementation which sounds more like a form of
"debugging". Sysfs represents the whole device model as seen from the
kernel.
And, sysfs is optional too (CONFIG_SYSFS).
>
> Also "debugX" doesn't sound like the proper place for a feature flag
> of the kernel. I just did a quick check on my system and I do see:
>
> $ ls /sys/fs/ext4/features
> batched_discard casefold encryption fast_commit lazy_itable_init
> meta_bg_resize metadata_csum_seed test_dummy_encryption_v2 verity
>
> Perhaps we need something similar for fs/ceph?
>
> --
> Patrick Donnelly, Ph.D.
> He / Him / His
> Principal Software Engineer
> Red Hat Sunnyvale, CA
> GPG: 19F28A586F808C2402351B93C3301A3E258DD79D
>
--
Cheers,
Venky
next prev parent reply other threads:[~2021-08-23 4:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 6:01 [RFC 0/2] ceph: add debugfs entries signifying new mount syntax support Venky Shankar
2021-08-18 6:01 ` [RFC 1/2] ceph: add helpers to create/cleanup debugfs sub-directories under "ceph" directory Venky Shankar
2021-08-18 11:34 ` Venky Shankar
2021-08-18 6:01 ` [RFC 2/2] ceph: add debugfs entries for v2 (new) mount syntax support Venky Shankar
2021-08-21 1:52 ` Patrick Donnelly
2021-08-23 4:45 ` Venky Shankar [this message]
2021-08-23 5:31 ` Venky Shankar
2021-08-23 10:32 ` Jeff Layton
2021-08-18 13:09 ` [RFC 0/2] ceph: add debugfs entries signifying new " Jeff Layton
2021-08-18 13:17 ` Venky Shankar
2021-08-18 13:23 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPzV1mPkwRmC-dA7oWNQ3=RsDPfw=tMJgw8sX_-CARy1UWH9w@mail.gmail.com' \
--to=vshankar@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jlayton@redhat.com \
--cc=pdonnell@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).