From: Pin-yen Lin <treapking@chromium.org>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Prashant Malani <pmalani@chromium.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>
Cc: "Xin Ji" <xji@analogixsemi.com>, "Marek Vasut" <marex@denx.de>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Lyude Paul" <lyude@redhat.com>,
devicetree@vger.kernel.org, "Stephen Boyd" <swboyd@chromium.org>,
dri-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org,
chrome-platform@lists.linux.dev,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Pin-yen Lin" <treapking@chromium.org>,
linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: [PATCH v15 05/10] drm/bridge: anx7625: Check for Type-C during panel registration
Date: Fri, 31 Mar 2023 17:11:40 +0800 [thread overview]
Message-ID: <20230331091145.737305-6-treapking@chromium.org> (raw)
In-Reply-To: <20230331091145.737305-1-treapking@chromium.org>
The output port endpoints can be connected to USB-C connectors.
Running drm_of_find_panel_or_bridge() with such endpoints leads to
a continuous return value of -EPROBE_DEFER, even though there is
no panel present.
To avoid this, check for the existence of a "mode-switch" property in
the port endpoint, and skip panel registration completely if so.
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
Changes in v15:
- Collect review tag
Changes in v14:
- Collect review tag
Changes in v13:
- Use the new typec_mode_switch_node_count helper
Changes in v12:
- Updated to use fwnode_for_each_typec_mode_switch macro
- Dropped collected tags
Changes in v10:
- Collected Reviewed-by and Tested-by tags
Changes in v6:
- New in v6
drivers/gpu/drm/bridge/analogix/anx7625.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 6846199a2ee1..3f6bf7674d32 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1648,7 +1648,8 @@ static int anx7625_get_swing_setting(struct device *dev,
static int anx7625_parse_dt(struct device *dev,
struct anx7625_platform_data *pdata)
{
- struct device_node *np = dev->of_node, *ep0;
+ struct device_node *np = dev->of_node, *ep0, *port_node;
+ unsigned int count;
int bus_type, mipi_lanes;
anx7625_get_swing_setting(dev, pdata);
@@ -1687,6 +1688,15 @@ static int anx7625_parse_dt(struct device *dev,
if (of_property_read_bool(np, "analogix,audio-enable"))
pdata->audio_en = 1;
+ /*
+ * Don't bother finding a panel if a Type-C `mode-switch` property is
+ * present in one of the endpoints in the output port.
+ */
+ port_node = of_graph_get_port_by_id(np, 1);
+ count = typec_mode_switch_node_count(&port_node->fwnode);
+ if (count)
+ return 0;
+
pdata->panel_bridge = devm_drm_of_get_bridge(dev, np, 1, 0);
if (IS_ERR(pdata->panel_bridge)) {
if (PTR_ERR(pdata->panel_bridge) == -ENODEV) {
--
2.40.0.348.gf938b09366-goog
next prev parent reply other threads:[~2023-03-31 9:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 9:11 [PATCH v15 00/10] Register Type-C mode-switch in DP bridge endpoints Pin-yen Lin
2023-03-31 9:11 ` [PATCH v15 01/10] device property: Add remote endpoint to devcon matcher Pin-yen Lin
2023-04-07 21:54 ` Stephen Boyd
2023-03-31 9:11 ` [PATCH v15 02/10] platform/chrome: cros_ec_typec: Purge blocking switch devlinks Pin-yen Lin
2023-03-31 9:11 ` [PATCH v15 03/10] drm/display: Add Type-C switch helpers Pin-yen Lin
2023-03-31 9:11 ` [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support Pin-yen Lin
2023-04-06 15:18 ` Rob Herring
2023-04-12 1:38 ` Stephen Boyd
2023-04-13 9:50 ` Pin-yen Lin
2023-04-14 0:22 ` Stephen Boyd
2023-04-20 6:10 ` Stephen Boyd
2023-04-20 9:10 ` Pin-yen Lin
2023-04-27 8:33 ` Pin-yen Lin
2023-04-29 4:47 ` Stephen Boyd
2023-05-10 3:41 ` Pin-yen Lin
2023-05-11 17:30 ` Stephen Boyd
2023-05-30 5:15 ` Pin-yen Lin
2023-05-30 6:25 ` Jagan Teki
2023-03-31 9:11 ` Pin-yen Lin [this message]
2023-03-31 9:11 ` [PATCH v15 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505 Pin-yen Lin
2023-03-31 9:11 ` [PATCH v15 07/10] drm/bridge: anx7625: Register Type C mode switches Pin-yen Lin
2023-03-31 9:11 ` [PATCH v15 08/10] dt-bindings: display: bridge: it6505: Add mode-switch support Pin-yen Lin
2023-04-06 15:15 ` Rob Herring
2023-04-06 15:50 ` Pin-yen Lin
2023-03-31 9:11 ` [PATCH v15 09/10] drm/bridge: it6505: Fix Kconfig indentation Pin-yen Lin
2023-03-31 9:11 ` [PATCH v15 10/10] drm/bridge: it6505: Register Type C mode switches Pin-yen Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331091145.737305-6-treapking@chromium.org \
--to=treapking@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hsinyi@chromium.org \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=pmalani@chromium.org \
--cc=rafael@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=swboyd@chromium.org \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).