From: Biju Das <biju.das.jz@bp.renesas.com>
To: Pavel Machek <pavel@denx.de>
Cc: "cip-dev@lists.cip-project.org" <cip-dev@lists.cip-project.org>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [cip-dev] [PATCH 4.19.y-cip] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC
Date: Tue, 13 Apr 2021 11:25:52 +0000 [thread overview]
Message-ID: <OS0PR01MB59225BADC1FF451D23669D85864F9@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210413112158.GA13447@duo.ucw.cz>
[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]
> Subject: Re: [PATCH 4.19.y-cip] drm: rcar-du: Fix crash when using LVDS1
> clock for CRTC
>
> Hi!
>
> > > > On D3 and E3 platforms, the LVDS encoder includes a PLL that can
> > > > generate a clock for the corresponding CRTC, used even when the
> > > > CRTC output to a non-LVDS port. This mechanism is supported by the
> > > > driver, but the implementation is broken in dual-link LVDS mode.
> > > > In that case, the LVDS1 drm_encoder is skipped, which causes a
> > > > crash when trying to access its bridge later on.
> > > >
> > > > Fix this by storing bridge pointers internally instead of
> > > > retrieving them from the encoder. The rcar_du_device encoders
> > > > field isn't used anymore and can be dropped.
> > >
> > > The patch looks okay to me. I'll test it and can apply it if it
> > > works okay.
> > >
> > > But I don't believe it is in our 5.10, so I'd like it to be
> > > submitted for 5.10, too.
>
> Applied and pushed out.
Thanks you.
Regards,
Biju
[-- Attachment #2: Type: text/plain, Size: 428 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6370): https://lists.cip-project.org/g/cip-dev/message/6370
Mute This Topic: https://lists.cip-project.org/mt/82032629/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2021-04-13 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210409161436.10953-1-biju.das.jz@bp.renesas.com>
2021-04-12 7:19 ` [cip-dev] [PATCH 4.19.y-cip] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC Nobuhiro Iwamatsu
2021-04-12 7:25 ` Biju Das
2021-04-13 10:12 ` Pavel Machek
2021-04-13 10:18 ` Biju Das
2021-04-13 11:21 ` Pavel Machek
2021-04-13 11:25 ` Biju Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB59225BADC1FF451D23669D85864F9@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=pavel@denx.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).