Hi Pavel, Thank you for the review. > -----Original Message----- > From: Pavel Machek > Sent: 09 March 2021 20:39 > To: Prabhakar Mahadev Lad > Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu ; Pavel Machek > ; Biju Das > Subject: Re: [PATCH 4.19.y-cip 21/40] arm64: dts: renesas: r8a774c0-cat874: Add support for > AISTARVISION MIPI Adapter V2.1 > > Hi! > > > + imx219_ep: endpoint { > > + clock-lanes = <0>; > > + data-lanes = <1 2>; > > + link-frequencies = /bits/ 64 <456000000>; > > + /* uncomment remote-endpoint property to tie imx219 to > > + * CSI2 also make sure remote-endpoint for ov5645 camera > > + * is commented and remote endpoint phandle in csi40_in > > + * is imx219_ep > > + */ > > This needs to be normal comment style, and it needs to contain > sentences. And it may be better to provide #ifdef for the alternate > configuration. > Agreed will fix that upstream. Cheers, Prabhakar > > + /* remote-endpoint = <&csi40_in>; */ > > Best regards, > Pavel > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany