cip-dev.lists.cip-project.org archive mirror
 help / color / mirror / Atom feed
From: "Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>
To: <jan.kiszka@siemens.com>, <cip-dev@lists.cip-project.org>
Subject: Re: [cip-dev] [isar-cip-core][PATCH 2/3] ci: Do not try to deploy the security image
Date: Mon, 31 Aug 2020 22:51:57 +0000	[thread overview]
Message-ID: <OSBPR01MB2983E24BF973CB4EB355A9B592510@OSBPR01MB2983.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <83d75816ceb5f74802ac0cec5292bf257ffc2d48.1598865682.git.jan.kiszka@siemens.com>

[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]

Hi,

> -----Original Message-----
> From: Jan Kiszka [mailto:jan.kiszka@siemens.com]
> Sent: Monday, August 31, 2020 6:21 PM
> To: cip-dev@lists.cip-project.org
> Cc: iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) <nobuhiro1.iwamatsu@toshiba.co.jp>
> Subject: [isar-cip-core][PATCH 2/3] ci: Do not try to deploy the security image
> 
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This is not used, and the image is not available, so it breaks the
> build.
> 
> Fixes: 3510f8a66f80 ("ci: Rewrite using extends")
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

I checked this patch. The problem has been fixed.

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Best regards,
  Nobuhiro

> ---
>  .gitlab-ci.yml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index cd25437..0b0a771 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -7,6 +7,7 @@ variables:
>    use_rt: enable
>    targz: enable
>    dtb: none
> +  deploy: enable
> 
>  stages:
>    - build
> @@ -30,7 +31,7 @@ default:
>      - if [ "${extention}" != "base" ]; then base_yaml="${base_yaml}:kas/opt/${extention}.yml"; fi;
>      - if [ "${targz}" = "enable" ]; then base_yaml="${base_yaml}:kas/opt/targz-img.yml"; fi;
>      - kas build ${base_yaml}
> -    - scripts/deploy-cip-core.sh ${release} ${target} ${extention} ${dtb}
> +    - if [ "${deploy}" = "enable" ]; then scripts/deploy-cip-core.sh ${release} ${target} ${extention} ${dtb}; fi
> 
>  # base image
>  build:simatic-ipc227e-base:
> @@ -68,6 +69,7 @@ build:qemu-amd64-base:
>      extention: security
>      use_rt: disable
>      targz: disable
> +    deploy: disable
> 
>  # test
>  build:simatic-ipc227e-test:
> --
> 2.26.2


[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#5343): https://lists.cip-project.org/g/cip-dev/message/5343
Mute This Topic: https://lists.cip-project.org/mt/76530563/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

  reply	other threads:[~2020-08-31 22:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31  9:21 [cip-dev] [isar-cip-core][PATCH 0/3] ci fixes Jan Kiszka
2020-08-31  9:21 ` [cip-dev] [isar-cip-core][PATCH 1/3] hihope-rzg2m: Align kas filename with machine name Jan Kiszka
2020-08-31 22:49   ` Nobuhiro Iwamatsu
2020-08-31  9:21 ` [cip-dev] [isar-cip-core][PATCH 2/3] ci: Do not try to deploy the security image Jan Kiszka
2020-08-31 22:51   ` Nobuhiro Iwamatsu [this message]
2020-08-31  9:21 ` [cip-dev] [isar-cip-core][PATCH 3/3] linux-cip Switch to gitlab source and update to 4.19.140-cip33 Jan Kiszka
2020-08-31 23:03   ` Nobuhiro Iwamatsu
2020-09-01 11:39     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSBPR01MB2983E24BF973CB4EB355A9B592510@OSBPR01MB2983.jpnprd01.prod.outlook.com \
    --to=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=cip-dev@lists.cip-project.org \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).