From: Denis Efremov <efremov@linux.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Coccinelle <cocci@systeme.lip6.fr>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Cocci] [PATCH] coccinelle: api: add sprintf() support to device_attr_show
Date: Fri, 14 Aug 2020 17:36:34 +0300 [thread overview]
Message-ID: <0a9015b6-9037-59c5-31f2-cd2b32c86b50@linux.com> (raw)
In-Reply-To: <48ffa436-6e73-88b2-07bc-89942f3c6d8e@web.de>
On 8/14/20 3:30 PM, Markus Elfring wrote:
>>> You propose to use a nested SmPL disjunction for desired adjustments.
>>> I suggest to start a corresponding case distinction behind
>>> the key word “return” instead of repeating it three times.
>>
>> It doesn't work.
>
> How do you think about to apply a SmPL rule variant like the following?
>
> @rp depends on patch@
> identifier show, dev, attr, buf;
> constant str;
> @@
>
> ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> <...
> return
> (
> - snprintf
> + sprintf
> (
> buf,
> - \(PAGE_SIZE\|PAGE_SIZE - 1\),
> ( str
> |
> ( "%i"\|"%i\n"\|"%li"\|"%li\n"\|"%lli"\|"%lli\n"\|
> "%d"\|"%d\n"\|"%ld"\|"%ld\n"\|"%lld"\|"%lld\n"\|
> "%u"\|"%u\n"\|"%lu"\|"%lu\n"\|"%llu"\|"%llu\n"\|
> "%x"\|"%x\n"\|"%lx"\|"%lx\n"\|"%llx"\|"%llx\n"\|
> "%X"\|"%X\n"\|"%lX"\|"%lX\n"\|"%llX"\|"%llX\n"\|
> "0x%x"\|"0x%x\n"\|"0x%lx"\|"0x%lx\n"\|"0x%llx"\|"0x%llx\n"\|
> "0x%X"\|"0x%X\n"\|"0x%lX"\|"0x%lX\n"\|"0x%llX"\|"0x%llX\n"\|
> "%02x\n"\|"%03x\n"\|"%04x\n"\|"%08x\n"\|
> "%02X\n"\|"%03X\n"\|"%04X\n"\|"%08X\n"\|
> "0x%02x\n"\|"0x%03x\n"\|"0x%04x\n"\|"0x%08x\n"\|
> "0x%02X\n"\|"0x%03X\n"\|"0x%04X\n"\|"0x%08X\n"\|
> "%zd"\|"%zd\n"\|"%zu"\|"%zu\n"\|"%zx"\|"%zx\n"\|
> "%c"\|"%c\n"\|"%p"\|"%p\n"\|"%pU\n"\|"%pUl\n"\|"%hu\n"
> ) ,
> ...
> )
> )
> |
> - snprintf
> + scnprintf
> (...)
> );
> ...>
> }
>
3 levels of nested disjunctions makes this pattern completely unreadable
and gives no comparable benefits. I don't think we should care much about
number of characters in the kernel sources, gzip will do a better job
anyway.
Thanks,
Denis
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-08-14 14:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ed9a8046-4c21-e849-f68b-9e08991b701d@web.de>
2020-08-14 8:50 ` [Cocci] [PATCH] coccinelle: api: add sprintf() support to device_attr_show Denis Efremov
[not found] ` <48ffa436-6e73-88b2-07bc-89942f3c6d8e@web.de>
2020-08-14 14:36 ` Denis Efremov [this message]
[not found] ` <047eaa85-20cf-800d-7087-a980f53572de@web.de>
2020-08-16 8:37 ` [Cocci] Searching for format strings with SmPL disjunctions Markus Elfring
2020-08-16 8:43 ` Julia Lawall
2020-08-16 8:48 ` Markus Elfring
2020-08-16 11:00 ` Markus Elfring
2020-08-15 10:32 ` [Cocci] [PATCH] coccinelle: api: add sprintf() support to device_attr_show Julia Lawall
2020-08-17 7:00 ` [Cocci] " Markus Elfring
2020-08-17 7:42 ` Julia Lawall
2020-08-17 7:57 ` Markus Elfring
2020-08-17 8:02 ` Julia Lawall
[not found] ` <cad4141c-8cba-3705-a502-0620ae3df027@web.de>
2020-08-17 8:24 ` Julia Lawall
[not found] ` <1e60d36d-7f2b-98eb-5fe3-9729b97ba360@web.de>
2020-08-17 16:29 ` Julia Lawall
[not found] ` <afbbc6f1-ca60-e780-0139-d944165e456f@web.de>
2020-09-05 7:39 ` Julia Lawall
[not found] ` <26349832-57a8-4c6e-efc9-0febd5650922@web.de>
2020-09-05 9:53 ` Julia Lawall
2020-09-05 11:08 ` Julia Lawall
2020-08-13 22:49 [Cocci] [PATCH] " Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a9015b6-9037-59c5-31f2-cd2b32c86b50@linux.com \
--to=efremov@linux.com \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).