cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Coccinelle <cocci@systeme.lip6.fr>
Subject: [Cocci] Checking adjustments for pointer resets with SmPL
Date: Mon, 21 Sep 2020 17:34:52 +0200	[thread overview]
Message-ID: <17fe1cf3-c85c-971d-8e59-65b666e91071@web.de> (raw)

Hello,

I have noticed the update suggestion “USB: quirks: simplify quirk handling”.
https://lore.kernel.org/linux-usb/20200921113039.GA19862@duo.ucw.cz/
https://lore.kernel.org/patchwork/patch/1308991/

Thus I converted a patch hunk into the following script variant for
the semantic patch language (according to the software “Coccinelle 1.0.8-00177-g28737419”).

@adjustment@
identifier allocate, object, release;
@@
-if (object)
-{
-release(object);
-object = NULL;
-}
+release(object);
 object = allocate(..., sizeof(...), ...);


Now I wonder at the moment why a known patch is not generated.
(An error message is not displayed.)

elfring@Sonne:~/Projekte/Linux/next-patched> spatch drivers/usb/core/quirks.c ~/Projekte/Coccinelle/janitor/simplify_pointer_reset2.cocci


Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

             reply	other threads:[~2020-09-21 17:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 15:34 Markus Elfring [this message]
2020-09-21 17:47 ` [Cocci] Checking adjustments for pointer resets with SmPL Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17fe1cf3-c85c-971d-8e59-65b666e91071@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).