From: Jaskaran Singh <jaskaransingh7654321@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "linux-kernel-mentees@lists.linuxfoundation.org"
<linux-kernel-mentees@lists.linuxfoundation.org>,
"cocci@systeme.lip6.fr" <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType
Date: Tue, 17 Mar 2020 10:58:32 +0530 [thread overview]
Message-ID: <3a335c7aef78ea5762248484a645eb5ff27b973c.camel@gmail.com> (raw)
In-Reply-To: <4d55d76c-29d1-1c88-d8ad-606e32a938d9@web.de>
On Mon, 2020-03-16 at 20:20 +0100, Markus Elfring wrote:
> > ParenType and FunctionType are added to the SmPL ASTs.
> > Add cases for these types in ….ml.
>
> A change description template was used several times.
> I wonder if there is really a need to modify only a single OCaml
> source file
> in these update steps.
> How do you think about to combine such changes in a bigger update
> step?
>
These are separated this way so that it's easier for Julia to review.
She will probably just squash all 26 of these together and apply them
later.
Cheers,
Jaskaran.
> Regards,
> Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-03-17 5:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 19:20 [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType Markus Elfring
2020-03-17 5:28 ` Jaskaran Singh [this message]
2020-03-17 8:40 ` [Cocci] [06/26] " Markus Elfring
2020-03-17 8:53 ` Julia Lawall
2020-03-17 8:57 ` Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-03-16 10:02 [Cocci] [PATCH 00/26] cocci: Add ParenType/FunctionType to SmPL ASTs Jaskaran Singh
2020-03-16 10:02 ` [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType Jaskaran Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a335c7aef78ea5762248484a645eb5ff27b973c.camel@gmail.com \
--to=jaskaransingh7654321@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).