From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>,
Denis Efremov <efremov@linux.com>,
Coccinelle <cocci@systeme.lip6.fr>
Cc: Michal Marek <michal.lkml@markovi.net>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Cocci] coccinelle: api: add kvfree script
Date: Sat, 6 Jun 2020 13:06:23 +0200 [thread overview]
Message-ID: <51a176d4-8c59-5da1-b4d2-c97b17b691a7@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2006060944320.2578@hadrien>
>>> + E = \(kmalloc@kok\|kzalloc@kok\|krealloc@kok\|kcalloc@kok\|kmalloc_node@kok\|kzalloc_node@kok\|kmalloc_array@kok\|kmalloc_array_node@kok\|kcalloc_node@kok\)(...)
>>
>> I would prefer an other coding style here.
>>
>> * Items for such SmPL disjunctions can be specified also on multiple lines.
>>
>> * The semantic patch language supports further means to handle function name lists
>> in more convenient ways.
>> Would you like to work with customised constraints?
>
> Please don't follow this advice.
I have got recurring understanding difficulties with such a response.
Will quoted patch review issues clarified in any other ways?
> Coccinelle is not able to optimize its search process according to
> the information in constraints. It will needlessly parse many files.
The software supports also SmPL constraints for some reasons.
Why should such functionality be used at all if the immediate reminder is
there seem to be more important optimisation aspects to consider before?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-06-06 11:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 7:30 [Cocci] [PATCH] coccinelle: api: add kvfree script Markus Elfring
2020-06-06 7:46 ` Julia Lawall
2020-06-06 9:50 ` [Cocci] " Markus Elfring
2020-06-07 14:02 ` [Cocci] Coccinelle: Extending capabilities for source file pre-selection Markus Elfring
2020-06-06 11:06 ` Markus Elfring [this message]
2020-06-06 11:11 ` [Cocci] coccinelle: api: add kvfree script Julia Lawall
2020-06-06 11:21 ` Markus Elfring
2020-06-07 6:42 ` [Cocci] Coccinelle: Improving software components around usage of SmPL disjunctions Markus Elfring
2020-06-06 14:04 [Cocci] [PATCH] coccinelle: api: add kvfree script Markus Elfring
2020-06-06 14:39 ` Julia Lawall
2020-06-06 15:10 ` [Cocci] " Markus Elfring
2020-06-14 15:10 Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51a176d4-8c59-5da1-b4d2-c97b17b691a7@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=efremov@linux.com \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).