cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Jaskaran Singh <jaskaransingh7654321@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr
Subject: Re: [Cocci] [RFC 00/25] cocci: Improve C parsing of attributes
Date: Sat, 25 Apr 2020 15:42:17 +0200	[thread overview]
Message-ID: <6ad88a23-8d78-f9c6-1040-ce0cf609ad55@web.de> (raw)
In-Reply-To: <081e4dc524343830ad7653473e54d86081db807b.camel@gmail.com>

>>> These parsing errors were discovered by running a build of
>>> Coccinelle's
>>
>> Would you like to omit the word “These”?
…
> Could you please keep your feedback relevant to the actual patch itself
> (or the commit messages)?

I contributed another review comment also at this place.


> Feedback like this really isn't relevant, unless these minor typos/
> grammartical errors cause a _lot_ of confusion.

I occasionally dare to suggest corresponding wording fine-tuning
so that the chances might increase to publish improved commits.

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

      reply	other threads:[~2020-04-25 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 12:02 [Cocci] [RFC PATCH 00/25] cocci: Improve C parsing of attributes Markus Elfring
2020-04-25 13:15 ` Jaskaran Singh
2020-04-25 13:42   ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ad88a23-8d78-f9c6-1040-ce0cf609ad55@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=jaskaransingh7654321@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).