From: Jaskaran Singh <jaskaransingh7654321@gmail.com>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Regression since recent parentypes patches were merged
Date: Wed, 13 May 2020 13:02:33 +0530 [thread overview]
Message-ID: <7c9f6da3779ca11e551224ca9efd06da5c569b56.camel@gmail.com> (raw)
In-Reply-To: <fa30c7d6-5278-9575-517b-31658b1a37c3@linbit.com>
On Tue, 2020-05-12 at 13:57 +0200, Christoph Böhmwalder wrote:
> Hi Jaskaran,
> Hi all,
>
> I have noticed a regression in spatch since the recent SmPL
> improvements
> were merged. Here is a small reproducer:
>
> @@
> struct socket *sock;
> struct sockaddr *uaddr;
> int peer;
> @@
> {
> +int ___addr_len;
> ...
> - sock->ops->getname(sock, uaddr, peer);
> + sock->ops->getname(sock, uaddr, &___addr_len, peer);
> ...
> }
>
>
> This used to parse just fine, however now it errors out:
>
>
> $ spatch --parse-cocci compat.cocci
> init_defs_builtins: /usr/local/bin/../lib/coccinelle/standard.h
> minus: parse error:
> File "compat.cocci", line 9, column 13, charpos = 98
> around = 'getname',
> whole content = - sock->ops->getname(sock, uaddr, peer);
>
>
> I have bisected the problem and it appears that the first bad commit
> is:
>
> commit c280375635f62dfbe052709e4e47a82140d32ce5
> Author: Jaskaran Singh <jaskaransingh7654321@gmail.com>
> Date: Fri Mar 20 12:31:32 2020 +0530
>
> Add parentypes to SmPL
>
> This allows the SmPL and C ASTs to better match up, which
> enables
> more transformations. The patch is very large, so I have left
> the different messages as they were proposed in the original
> patch series.
>
> Which is unfortunately huge, and since it was squashed together I
> really
> can't be any more specific.
>
> Anyways, is this a bug? Or was I doing something wrong in the first
> place?
>
Hi Christoph,
I've sent a patch for this, it should be merged after review. Sorry for
the inconvenience!
Cheers,
Jaskaran.
> Thanks and best regards,
> --
> Christoph Böhmwalder
> LINBIT | Keeping the Digital World Running
> DRBD HA — Disaster Recovery — Software defined Storage
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-05-13 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 11:57 [Cocci] Regression since recent parentypes patches were merged Christoph Böhmwalder
2020-05-12 12:30 ` Julia Lawall
2020-05-13 7:32 ` Jaskaran Singh [this message]
2020-05-13 11:13 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c9f6da3779ca11e551224ca9efd06da5c569b56.camel@gmail.com \
--to=jaskaransingh7654321@gmail.com \
--cc=christoph.boehmwalder@linbit.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).