Re: [Cocci] linux-kernel janitorial RFP: Mark static arrays as const

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
Cc: Joe Perches <joe@perches.com>, cocci <cocci@systeme.lip6.fr>,
	kernel-janitors <kernel-janitors@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernelnewbies <kernelnewbies@kernelnewbies.org>
Subject: Re: [Cocci] linux-kernel janitorial RFP: Mark static arrays as const
Date: Thu, 4 Mar 2021 10:34:52 +0200	[thread overview]
Message-ID: <CAHp75Vfy+63qnRWd4mp1ZkLeEw6XaRxHXzUBXtw8SA4dbuGskg@mail.gmail.com> (raw)
In-Reply-To: <22d22edd-4213-0f57-d801-1c570f04ec05@petrovitsch.priv.at>

[-- Attachment #1.1: Type: text/plain, Size: 2179 bytes --]

On Wednesday, March 3, 2021, Bernd Petrovitsch <bernd@petrovitsch.priv.at>
wrote:

> Hi all!
>
> On 02/03/2021 18:42, Joe Perches wrote:
> [...]
> > ------------- For instance: (head -10 of the git grep for file statics)
> >
> > drivers/accessibility/speakup/keyhelp.c:18:static u_short masks[] = {
> 32, 16, 8, 4, 2, 1 };
> > drivers/accessibility/speakup/keyhelp.c:26:static u_char funcvals[] = {
> > drivers/accessibility/speakup/main.c:2059:static spkup_hand
> spkup_handler[] = {
> > drivers/accessibility/speakup/speakup_acntpc.c:35:static unsigned int
> synth_portlist[] = { 0x2a8, 0 };
> > drivers/accessibility/speakup/speakup_decpc.c:133:static int
> synth_portlist[] = { 0x340, 0x350, 0x240, 0x250, 0 };
> > drivers/accessibility/speakup/speakup_dectlk.c:110:static int
> ap_defaults[] = {122, 89, 155, 110, 208, 240, 200, 106, 306};
> > drivers/accessibility/speakup/speakup_dectlk.c:111:static int
> g5_defaults[] = {86, 81, 86, 84, 81, 80, 83, 83, 73};
> > drivers/accessibility/speakup/speakup_dtlk.c:34:static unsigned int
> synth_portlist[] = {
> > drivers/accessibility/speakup/speakup_keypc.c:34:static unsigned int
> synth_portlist[] = { 0x2a8, 0 };
> > drivers/acpi/ac.c:137:static enum power_supply_property ac_props[] = {
> >
> > For drivers/accessibility/speakup/keyhelp.c:18:static u_short masks[] =
> { 32, 16, 8, 4, 2, 1 };
>
> Looking at the examples: Just s/^static /static const / in the lines
> reported by the grep's above and see if it compiles (and save space)?

I did two reverts and reported at least one issue with blind
constification. Besides that we have a lot of data structures that require
to drop const spécifier and the consumer won’t actually know if it’s
possible to write there or not. I’m talking about driver data fields where
they are defined as type of kernel_ulong_t. So, first you need to fix that,

>
> MfG,
>         Bernd
> --
> Bernd Petrovitsch                  Email : bernd@petrovitsch.priv.at
>      There is NO CLOUD, just other people's computers. - FSFE
>                      LUGA : http://www.luga.at
>

-- 
With Best Regards,
Andy Shevchenko

[-- Attachment #1.2: Type: text/html, Size: 2791 bytes --]

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci