From: Julia Lawall <julia.lawall@inria.fr>
To: David Frey <dpfrey@gmail.com>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] Problem writing simple patch
Date: Mon, 25 Nov 2019 22:10:30 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1911252208260.2656@hadrien> (raw)
In-Reply-To: <c156dbfc-8c3d-4750-fa90-2bbd11060130@gmail.com>
On Mon, 25 Nov 2019, David Frey wrote:
> Hi,
>
> I'm trying to write a .cocci file to transform all calls to a function
> "f(ex)" to something like this:
>
> #ifdef USE_F
> f(ex)
> #else
> g(ex)
> #endif
>
> The function has this signature:
> bool f(int x);
>
> This is the patch that I tried to use:
> @@
> expression ex;
> @@
> +#ifdef USE_F
> f(ex)
> +#else
> +g(ex)
> +#endif
>
>
> This is the result of running it:
> $ spatch --show-c --sp-file test.cocci test.c
> init_defs_builtins: /usr/bin/../lib/coccinelle/standard.h
> plus: parse error:
> File "test.cocci", line 7, column 1, charpos = 50
> around = 'g',
> whole content = +g(ex)
>
> What is wrong with the patch above?
Coccinelle doesn't currently support adding ifdefs on expressions, only on
statements.
You could try for some typical usage contexts, like
+ifdef...
x = f(ex);
+#else
+x = g(ex);
+#endif
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-11-25 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 19:57 [Cocci] Problem writing simple patch David Frey
2019-11-25 21:10 ` Julia Lawall [this message]
2019-11-26 7:24 ` [Cocci] Specifying conditional compilation with SmPL Markus Elfring
2019-11-26 7:47 ` Julia Lawall
2019-11-26 23:46 ` [Cocci] Problem writing simple patch David Frey
2019-11-27 6:00 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911252208260.2656@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=dpfrey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).