From: Julia Lawall <julia.lawall@inria.fr>
To: Timur Tabi <timur@kernel.org>
Cc: cocci <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Concatenating parameters into a string
Date: Mon, 13 Jan 2020 23:33:50 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2001132332060.2574@hadrien> (raw)
In-Reply-To: <CAOZdJXU4vhqzot5EEMZ_9jAdp-Be0TTyDS-uXJVPrGs2k=c7nA@mail.gmail.com>
On Mon, 13 Jan 2020, Timur Tabi wrote:
> I don't know how to properly describe what I'm trying to do, so I'll
> just show an example.
>
> The code I'm working on has dozens of annoying macros that concatenate
> parameters into strings. For example,
>
> #define DRF_DEF(d,r,f,c) \
> (((NvU32)(NV ## d ## r ## f ## c))<<DRF_SHIFT(NV ## d ## r ## f))
>
> So given DRF_DEF(one, two, three, four), it will generated:
>
> (((NvU32)(NV_one_two_three_four))<<DRF_SHIFT(NV_one_two_three))
>
> I'm trying to create a cocci rule that will replace all of these
> macros with their expanded equivalents, but I don't know how to handle
> the ## feature of macros. So far I have this:
>
> @@
> expression d, r, f, n, v;
> @@
> -FLD_SET_DRF_NUM(d, r, f, n, v)
> +((v) & ~DRF_SHIFTMASK(NV d r f)) | DRF_NUM(d, r, f, n)
Sorry, I don't follow what you are trying to do here. Could you send an
example of the desired before after C code? I see what you have above,
but I don't see the connection to the rule you have tried to write.
I have the feeling that you will want to use some python code to do
something with the ##s, but I'm not sure.
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-01-13 22:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 22:21 [Cocci] Concatenating parameters into a string Timur Tabi
2020-01-13 22:33 ` Julia Lawall [this message]
2020-01-13 22:46 ` Timur Tabi
2020-01-13 23:04 ` Julia Lawall
2020-01-14 0:01 ` Timur Tabi
2020-01-14 7:16 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2001132332060.2574@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).