From: Julia Lawall <julia.lawall@inria.fr>
To: Jaskaran Singh <jaskaransingh7654321@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH] parsing_c: Handle case of macro before typedef
Date: Tue, 21 Jan 2020 06:28:13 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.21.2001210626540.2301@hadrien> (raw)
In-Reply-To: <20200119134610.31961-1-jaskaransingh7654321@gmail.com>
On Sun, 19 Jan 2020, Jaskaran Singh wrote:
> For the following case:
>
> <macro> <typedef> <identifier>
>
> A case in parsing_hacks.ml sometimes mislabels <macro> as a
> typedef ident.
>
> If typedef is a known typedef (such as u8 or *_t), then label
> <macro> as a CppMacro. Subsequent cases will then label <typedef>
> correctly.
OK, I see that you are now using is_known_typdef in a more interesting
way. Could you add a test case that shows what has improved? I would
still know to know why the number of passed tokens increases.
julia
>
> Following are results of --parse-c on the Linux Kernel v5.5-rc4:
>
> Before:
>
> nb good = 18956150, nb passed = 134061 =========> 0.70% passed
>
> After:
>
> nb good = 18956150, nb passed = 134062 =========> 0.70% passed
>
> Signed-off-by: Jaskaran Singh <jaskaransingh7654321@gmail.com>
> ---
> parsing_c/parsing_hacks.ml | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/parsing_c/parsing_hacks.ml b/parsing_c/parsing_hacks.ml
> index 8374731b..23d675cf 100644
> --- a/parsing_c/parsing_hacks.ml
> +++ b/parsing_c/parsing_hacks.ml
> @@ -2184,6 +2184,41 @@ let lookahead2 ~pass next before =
> && ok_typedef s && is_macro s2 && is_type type_
> ->
> TIdent (s, i1)
> +
> + (* xx yy zz : xx is a macro *)
> + | (TIdent (s, i1)::TIdent (s2, i2)::TIdent(_,_)::_ , _)
> + when not_struct_enum before
> + && ok_typedef s2
> + && is_known_typdef s2
> + ->
> + TCommentCpp(Token_c.CppMacro, i1)
> +
> + (* xx yy zz : xx is a typedef ident *)
> + | (TIdent (s, i1)::TIdent (s2, i2)::TIdent(_,_)::_ , _)
> + when not_struct_enum before
> + && ok_typedef s
> + ->
> + msg_typedef s i1 2; LP.add_typedef_root s i1;
> + TypedefIdent (s, i1)
> +
> + (* xx yy * zz : xx is a macro *)
> + | (TIdent (s, i1)::TIdent (s2, i2)::ptr , _)
> + when pointer ~followed_by:(function TIdent _ -> true | _ -> false) ptr
> + && not_struct_enum before
> + && ok_typedef s2
> + && is_known_typdef s2
> + ->
> + TCommentCpp(Token_c.CppMacro, i1)
> +
> + (* xx yy * zz : xx is a typedef ident *)
> + | (TIdent (s, i1)::TIdent (s2, i2)::ptr , _)
> + when pointer ~followed_by:(function TIdent _ -> true | _ -> false) ptr
> + && not_struct_enum before
> + && ok_typedef s
> + ->
> + msg_typedef s i1 2; LP.add_typedef_root s i1;
> + TypedefIdent (s, i1)
> +
> (* xx yy *)
> | (TIdent (s, i1)::TIdent (s2, i2)::rest , _) when not_struct_enum before
> && ok_typedef s && not (is_macro_paren s2 rest)
> --
> 2.21.1
>
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-01-21 6:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 13:46 [Cocci] [PATCH] parsing_c: Handle case of macro before typedef Jaskaran Singh
2020-01-21 6:28 ` Julia Lawall [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-21 9:35 Markus Elfring
2020-01-19 13:18 Jaskaran Singh
2020-01-19 13:25 ` Jaskaran Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2001210626540.2301@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=jaskaransingh7654321@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).