From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH v2 0/3] cocci: Improve management of macros before typedefs
Date: Tue, 21 Jan 2020 10:43:08 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.21.2001211042120.5988@hadrien> (raw)
In-Reply-To: <7f56dadb-0fde-359c-2b88-f812b0858ac8@web.de>
On Tue, 21 Jan 2020, Markus Elfring wrote:
> > If <typedef> is a known typedef (such as u8 or *_t) then label <macro>
> > as a CppMacro. Subsequent cases will label <typedef> correctly as a
> > typedef ident.
> >
> > Also add bool to the list of known typedefs so that cases of
>
> Can a wording like the following be nicer for such a change description?
>
> Label <macro> as a CppMacro if <typedef> is a known type definition
> (such as u8 or *_t).
> Subsequent cases will label <typedef> correctly as a type definition identifier.
Actually, there is a piece of important information that is missing in
both of these messages. It would be nice to say "Subsequent cases will
continue to label...".
julia
>
> Add bool also to the list of known type definition identifiers so that cases of
>
>
> Regards,
> Markus
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-01-21 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 9:56 [Cocci] [PATCH v2 0/3] cocci: Improve management of macros before typedefs Markus Elfring
2020-01-21 10:43 ` Julia Lawall [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-21 8:04 Jaskaran Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2001211042120.5988@hadrien \
--to=julia.lawall@inria.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).