From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Michal Marek <michal.lkml@markovi.net>,
Gilles Muller <Gilles.Muller@lip6.fr>,
kernel-janitors@vger.kernel.org,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] [v2 1/4] coccinelle: api: extend memdup_user transformation with GFP_USER
Date: Sat, 18 Jul 2020 08:45:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2007180841520.2538@hadrien> (raw)
In-Reply-To: <0b9f2c58-e124-22d2-d91d-62a6e831c880@web.de>
On Sat, 18 Jul 2020, Markus Elfring wrote:
> > Applied.
>
> Do you care for patch review concerns according to this SmPL script adjustment?
>
> * https://lore.kernel.org/cocci/5c0dae88-e172-3ba6-f86c-d1a6238bb4c4@web.de/
> https://lkml.org/lkml/2020/6/9/568
This one it complete nonsense.
>
> * https://lore.kernel.org/cocci/c3464cad-e567-9ef5-b4e3-a01e3b11120b@web.de/
> https://lkml.org/lkml/2020/6/8/637
This on is indeed a problem. I think it was not detected in testing,
because in the current kernel the rule never applies. But Denis, in
- to = \(kmalloc\|kzalloc\)
(size,\(GFP_KERNEL\|GFP_USER\|
\(GFP_KERNEL\|GFP_USER\)|__GFP_NOWARN\));
you do indeed need to put - in front of the second and third lines as
well.
Markus, if you would limit your comments to suggesting SmPL code that is
actually correct, ie that you have tested, and 2) stop suggesting stupid
things over and over like that putting all of the virtual declarations on
the same line would save space (it does, but who cares), then I would take
your suggestions more seriously.
julia
> Regards,
> Markus
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next parent reply other threads:[~2020-07-18 6:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0b9f2c58-e124-22d2-d91d-62a6e831c880@web.de>
2020-07-18 6:45 ` Julia Lawall [this message]
[not found] ` <fa0ec546-9aee-5c95-428c-a225a3521f6f@web.de>
2020-07-18 8:41 ` [Cocci] [v2 1/4] coccinelle: api: extend memdup_user transformation with GFP_USER Julia Lawall
2020-07-18 13:11 ` Denis Efremov
2020-07-18 13:29 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2007180841520.2538@hadrien \
--to=julia.lawall@inria.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).