cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Michal Marek <michal.lkml@markovi.net>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-doc@vger.kernel.org, Nicolas Palix <nicolas.palix@imag.fr>,
	linux-kernel@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	Coccinelle <cocci@systeme.lip6.fr>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: Re: [Cocci] [PATCH v3] documentation: coccinelle: Improve command example for make C={1, 2}
Date: Mon, 10 Aug 2020 22:52:37 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2008102249570.2466@hadrien> (raw)
In-Reply-To: <478715f8-87dd-7b4d-d3fd-01585f5f3bd7@web.de>

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]



On Mon, 10 Aug 2020, Markus Elfring wrote:

> > the usage of the makefile C variable flag by coccicheck.
>
> * Can it be confusing to denote an item as a variable and a flag?
>
> * Would you really like to stress here that a flag can be variable?

This is not part of the documentation, so it doesn't really matter.

Nevertheless, Sumera, there is stail an occurrence of flag in the proposed
change to the documentation, so you could indeed change that one to
variable.

>
>
> > +This variable can be used to run scripts for …
>
> Can the scope for a make command be selected also without such a variable?

If you know something that is different than what is in the documentation,
then please say what it is.  Don't just ask questions.

> Will clarification requests for previously mentioned background information
> influence the proposed descriptions any further?

The point is to document the use of make coccicheck, not the C variables.
So the point about KBUILD_CHECK, while interesting, does not seem
appropriate for this documentation.

julia

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply	other threads:[~2020-08-10 20:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 20:16 [Cocci] [PATCH v3] documentation: coccinelle: Improve command example for make C={1, 2} Markus Elfring
2020-08-10 20:52 ` Julia Lawall [this message]
     [not found]   ` <d6dcb49d-3dca-327e-e782-2cae789e31b7@web.de>
2020-08-11  8:24     ` [Cocci] [v3] " Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2020-08-10 17:59 [Cocci] [PATCH v3] " Sumera Priyadarsini
2020-08-10 20:05 ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2008102249570.2466@hadrien \
    --to=julia.lawall@inria.fr \
    --cc=Gilles.Muller@lip6.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=rdunlap@infradead.org \
    --cc=sam@ravnborg.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).