Re: [Cocci] [PATCH] coccinnelle: Remove ptr_ret script

From: Julia Lawall <julia.lawall@inria.fr>
To: Maxime Ripard <maxime@cerno.tech>
Cc: michal.lkml@markovi.net, Gilles.Muller@lip6.fr,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	nicolas.palix@imag.fr, linux-kernel@vger.kernel.org,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Julia Lawall <Julia.Lawall@lip6.fr>,
	Mark Brown <broonie@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH] coccinnelle: Remove ptr_ret script
Date: Tue, 15 Dec 2020 09:52:36 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2012150950440.2879@hadrien> (raw)
In-Reply-To: <20201215084823.towbaqay5tgdh7dw@gilmour>

On Tue, 15 Dec 2020, Maxime Ripard wrote:

> Hi,
>
> On Tue, Jan 07, 2020 at 11:29:54AM +0100, Wolfram Sang wrote:
> > On Tue, Jan 07, 2020 at 11:06:56AM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 7 Jan 2020, Maxime Ripard wrote:
> > >
> > > > The ptr_ret script script addresses a number of situations where we end up
> > > > testing an error pointer, and if it's an error returning it, or return 0
> > > > otherwise to transform it into a PTR_ERR_OR_ZERO call.
> > > >
> > > > So it will convert a block like this:
> > > >
> > > > if (IS_ERR(err))
> > > >     return PTR_ERR(err);
> > > >
> > > > return 0;
> > > >
> > > > into
> > > >
> > > > return PTR_ERR_OR_ZERO(err);
> > > >
> > > > While this is technically correct, it has a number of drawbacks. First, it
> > > > merges the error and success path, which will make it harder for a reviewer
> > > > or reader to grasp.
> > > >
> > > > It's also more difficult to extend if we were to add some code between the
> > > > error check and the function return, making the author essentially revert
> > > > that patch before adding new lines, while it would have been a trivial
> > > > addition otherwise for the rewiever.
> > > >
> > > > Therefore, since that script is only about cosmetic in the first place,
> > > > let's remove it since it's not worth it.
> > > >
> > > > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > > Cc: Mark Brown <broonie@kernel.org>
> > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > >
> > > Acked-by: Julia Lawall <julia.lawall@inria.fr>
> >
> > Convincing patch description, good catch!
> >
> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> It looks like this patch was never applied, whose tree should it go
> through?

Sorry.  I can take it.  I'm not sure that I still have the original
message, though.  If you have it handy, that would be helpful.

julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci