From: Markus Elfring <Markus.Elfring@web.de>
To: Coccinelle <cocci@systeme.lip6.fr>
Subject: [Cocci] Checking data processing for parentheses in SmPL scripts
Date: Mon, 11 Nov 2019 17:47:18 +0100 [thread overview]
Message-ID: <c86eccbc-a1f3-50fa-34bf-f8fefdd3036f@web.de> (raw)
Hello,
The following change specification gets accepted by the Coccinelle software.
@@
expression X;
@@
-((X-1)&X) == 0
+powerof2(X)
See also:
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/722c3b8b6376deab9407ff00b5e63018ab3aef0b/test/cocci/useful_macros.cocci#L53
I got into the development mood to try another code variant out
for the semantic patch language.
@adjustment@
expression X;
@@
+powerof2(
-(X-1)&
X)
- == 0
Unfortunately, the error message “unexpected close parenthesis in line 6”
is reported then.
Can an other change variation make sense finally?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next reply other threads:[~2019-11-11 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 16:47 Markus Elfring [this message]
2019-11-12 8:04 ` [Cocci] Checking data processing for parentheses in SmPL scripts Markus Elfring
2019-11-12 13:23 ` Julia Lawall
2019-11-12 16:01 ` Markus Elfring
2019-11-12 16:07 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c86eccbc-a1f3-50fa-34bf-f8fefdd3036f@web.de \
--to=markus.elfring@web.de \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).