connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: John Keeping <john@metanate.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH] agent: Always inform upper layer via callback
Date: Wed, 30 Jun 2021 09:35:19 +0200	[thread overview]
Message-ID: <20210630073519.r6zvbhs6cbbzs2an@beryllium.lan> (raw)
In-Reply-To: <20210629114842.2d8a486d.john@metanate.com>

Hi John,

On Tue, Jun 29, 2021 at 11:48:42AM +0100, John Keeping wrote:
> On Tue, 29 Jun 2021 09:33:26 +0200
> Daniel Wagner <wagi@monom.org> wrote:
> 
> > The upper state machine expects to be called in all cases. Do not
> > silenty eat up the callback.
> > 
> > Fixes: 8ea2d67a6e89 ("service: Complete only after user connection retries")
> > Reported by John Keeping
> 
> Tested-by: John Keeping <john@metanate.com>
> 
> I've run through a few tests with this patch and it looks good!
> 
> Thanks for tracking down the issue here.

Thanks for testing. Patch applied.
Daniel

      reply	other threads:[~2021-06-30  7:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29  7:33 [PATCH] agent: Always inform upper layer via callback Daniel Wagner
2021-06-29 10:48 ` John Keeping
2021-06-30  7:35   ` Daniel Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210630073519.r6zvbhs6cbbzs2an@beryllium.lan \
    --to=wagi@monom.org \
    --cc=connman@lists.linux.dev \
    --cc=john@metanate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).