Re: [PATCH] dnsproxy: add standalone test version of dnsproxy and a test script for it

[Daniel Wagner <wagi@monom.org>]

Hi Matthias,

On Mon, Feb 28, 2022 at 02:19:21PM +0100, matthias.gerstner@suse.de wrote:
>  if TEST
>  testdir = $(pkglibdir)/test
>  test_SCRIPTS = $(test_scripts)
> +
> +tools_dnsproxy_standalone_CFLAGS = $(src_connmand_CFLAGS) -I$(srcdir)/src
> +tools_dnsproxy_standalone_SOURCES = tools/dnsproxy-standalone.c $(src_connmand_SOURCES)
> +# for EXTRA_PROGRAMS the BUILT_SOURCES aren't automatically added as
> +# dependency, so let's do it explicitly
> +tools/dnsproxy-standalone.c: $(BUILT_SOURCES)
> +tools_dnsproxy_standalone_LDADD = $(src_connmand_LDADD)
> +# pass -zmuldefs to let the linker tolerate the duplicate definition of
> +# main(), the first definition from dnsproxy-standalone should be used
> +tools_dnsproxy_standalone_LDFLAGS = $(src_connmand_LDFLAGS) -Wl,-zmuldefs
> +
> +noinst_PROGRAMS += tools/dnsproxy-standalone
> +

I wrapped this section into an addition 'if INTERNAL_DNS_BACKEND'
because it would fail to build for SYSTEMD_RESOLVED_DNS_BACKEND

> +	// we need to trick a bit to make the server entry enter "enabled"
> +	// state in dnsproxy. Appending and removing an arbitrary entry causes
> +	// "enable_fallback()" to be called which does what we want. Doesn't
> +	// make much sense but it is good enough for the standalone server at
> +	// the moment.

Changed this to /* ... */

Patch applied.

Thanks
Daniel