connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: Brian Fukano <bfukano@gmail.com>, connman@lists.linux.dev
Subject: Re: [PATCH v3] dnsproxy: fix signedness warnings
Date: Wed, 17 Apr 2024 15:27:48 -0500	[thread overview]
Message-ID: <434da666-080e-49d6-9b29-c8fdeeba8b18@gmail.com> (raw)
In-Reply-To: <20240405165801.72338-1-bfukano@gmail.com>

Hi Brian,

>   	 * The cached packet contains always the TCP offset (two bytes)
> @@ -508,7 +513,7 @@ static void send_cached_response(int sk, const unsigned char *ptr, size_t len,
>   	if (answers == 0)
>   		hdr->aa = 1;
>   	else {
> -		const int adj_len = len - 2;
> +		const size_t adj_len = len - 2;
>   		update_cached_ttl((unsigned char *)hdr, adj_len, ttl);
>   	}
>   

I dropped this chunk when applying.

Regards,
-Denis

      reply	other threads:[~2024-04-17 20:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 16:58 [PATCH v3] dnsproxy: fix signedness warnings Brian Fukano
2024-04-17 20:27 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=434da666-080e-49d6-9b29-c8fdeeba8b18@gmail.com \
    --to=denkenz@gmail.com \
    --cc=bfukano@gmail.com \
    --cc=connman@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).