connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Jussi Laakkonen <jussi.laakkonen@jolla.com>
To: Daniel Wagner <wagi@monom.org>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH v2 1/2] vpn-provider: Implement connmand online state checking
Date: Thu, 19 Aug 2021 15:40:04 +0300	[thread overview]
Message-ID: <5f76dcbc-8e93-61fe-8d7b-6b0aa7bcb786@jolla.com> (raw)
In-Reply-To: <20210819123003.r4sqio2pquco5qph@carbon.lan>

Hi Daniel,

On 8/19/21 3:30 PM, Daniel Wagner wrote:
> Hi Jussi,
> 
> On Thu, Aug 19, 2021 at 03:11:21PM +0300, Jussi Laakkonen wrote:
>> Sorry, I spotted some error with this as apparently our fork has something
>> again done differently somewhere. I'll send another version when I find the
>> cause. Does not seem to function correctly on top of 1.40.
> 
> No worries.
> 
> BTW, the question on the busy loop. I am pretty sure there is no timeout
> involved if you just return 'continue'. This tells the caller to queue
> up the callback again without any delay. At least this is how I remember
> it.
> 

I'm fairly confident in that the function is just returned back to the 
normal schedule when returning G_SOURCE_CONTINUE/TRUE.

But the issue is about VPN agent usage actually which is caused by the 
different - and quite possibly invalid use of VPN agent in our case. We 
always have an agent connected so that is our OS specific case which 
after all these years I completely forgot. But after checking with AntiX 
the issue is completely different. I need to dig into that again.

Cheers,
  Jussi



  parent reply	other threads:[~2021-08-19 12:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 15:14 [PATCH 0/2] Implement connmand state monitoring to vpnd Jussi Laakkonen
2021-08-17 15:14 ` [PATCH 1/2] vpn-provider: Implement connmand online state checking Jussi Laakkonen
2021-08-17 16:55   ` Daniel Wagner
2021-08-18  9:21     ` Jussi Laakkonen
2021-08-18 10:31   ` [PATCH v2 " Jussi Laakkonen
2021-08-19 12:11     ` Jussi Laakkonen
2021-08-19 12:30       ` Daniel Wagner
2021-08-19 12:38         ` Santtu Lakkala
2021-08-19 13:06           ` Daniel Wagner
2021-08-19 12:40         ` Jussi Laakkonen [this message]
2021-08-29 18:27           ` Daniel Wagner
2021-08-30  6:59             ` Jussi Laakkonen
2021-08-30  8:11               ` Daniel Wagner
2021-08-20 13:05   ` [PATCH v3 " Jussi Laakkonen
2021-08-17 15:14 ` [PATCH 2/2] vpn: Handle ENOLINK error in connect callback Jussi Laakkonen
2021-08-20 13:06   ` [PATCH v2 2/2] vpn: Refactor connect_reply() and handle NoCarrier -> ENOLINK error Jussi Laakkonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f76dcbc-8e93-61fe-8d7b-6b0aa7bcb786@jolla.com \
    --to=jussi.laakkonen@jolla.com \
    --cc=connman@lists.linux.dev \
    --cc=wagi@monom.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).