From: Mike Rapoport <rppt@kernel.org>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
SeongJae Park <sj@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Lorenzo Stoakes <lstoakes@gmail.com>,
Uladzislau Rezki <urezki@gmail.com>, Zi Yan <ziy@nvidia.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
damon@lists.linux.dev, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 1/5] mm: vmalloc must set pte via arch code
Date: Wed, 24 May 2023 21:47:21 +0300 [thread overview]
Message-ID: <20230524184721.GO4967@kernel.org> (raw)
In-Reply-To: <20230518110727.2106156-2-ryan.roberts@arm.com>
On Thu, May 18, 2023 at 12:07:23PM +0100, Ryan Roberts wrote:
> It is bad practice to directly set pte entries within a pte table.
> Instead all modifications must go through arch-provided helpers such as
> set_pte_at() to give the arch code visibility and allow it to check
> (and potentially modify) the operation.
>
> Fixes: 3e9a9e256b1e ("mm: add a vmap_pfn function")
> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
> Reviewed-by: Zi Yan <ziy@nvidia.com>
> Acked-by: Lorenzo Stoakes <lstoakes@gmail.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>
> ---
> mm/vmalloc.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 9683573f1225..48202ec5f79a 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2899,10 +2899,16 @@ struct vmap_pfn_data {
> static int vmap_pfn_apply(pte_t *pte, unsigned long addr, void *private)
> {
> struct vmap_pfn_data *data = private;
> + unsigned long pfn = data->pfns[data->idx];
> + pte_t ptent;
>
> - if (WARN_ON_ONCE(pfn_valid(data->pfns[data->idx])))
> + if (WARN_ON_ONCE(pfn_valid(pfn)))
> return -EINVAL;
> - *pte = pte_mkspecial(pfn_pte(data->pfns[data->idx++], data->prot));
> +
> + ptent = pte_mkspecial(pfn_pte(pfn, data->prot));
> + set_pte_at(&init_mm, addr, pte, ptent);
> +
> + data->idx++;
> return 0;
> }
>
> --
> 2.25.1
>
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2023-05-24 18:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 11:07 [PATCH v2 0/5] Encapsulate PTE contents from non-arch code Ryan Roberts
2023-05-18 11:07 ` [PATCH v2 1/5] mm: vmalloc must set pte via arch code Ryan Roberts
2023-05-19 12:09 ` Uladzislau Rezki
2023-05-24 18:47 ` Mike Rapoport [this message]
2023-05-18 11:07 ` [PATCH v2 2/5] mm: damon must atomically clear young on ptes and pmds Ryan Roberts
2023-05-18 17:13 ` SeongJae Park
2023-05-19 8:53 ` Ryan Roberts
2023-05-18 23:19 ` Yu Zhao
2023-05-19 9:02 ` Ryan Roberts
2023-05-19 19:54 ` SeongJae Park
2023-05-22 8:53 ` Ryan Roberts
2023-05-24 18:49 ` Mike Rapoport
2023-05-18 11:07 ` [PATCH v2 3/5] mm: Fix failure to unmap pte on highmem systems Ryan Roberts
2023-05-24 18:59 ` Mike Rapoport
2023-05-18 11:07 ` [PATCH v2 4/5] mm: Add new ptep_deref() helper to fully encapsulate pte_t Ryan Roberts
2023-05-18 19:28 ` Yu Zhao
2023-05-19 9:12 ` Ryan Roberts
2023-05-25 9:08 ` Ryan Roberts
2023-05-26 2:02 ` Yu Zhao
2023-05-24 19:06 ` Mike Rapoport
2023-05-24 19:11 ` Ryan Roberts
2023-05-18 11:07 ` [PATCH v2 5/5] mm: ptep_deref() conversion Ryan Roberts
2023-05-18 12:08 ` Jason Gunthorpe
2023-05-18 17:22 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524184721.GO4967@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=sj@kernel.org \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).