damon.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: haoxin <xhao@linux.alibaba.com>
To: SeongJae Park <sj@kernel.org>
Cc: akpm@linux-foundation.org, damon@lists.linux.dev,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/2] mm/damon/lru_sort: Remove struct of damon_lru_sort_ram_walk_arg
Date: Fri, 19 Aug 2022 09:56:53 +0800	[thread overview]
Message-ID: <5bc7f671-ad41-6a0c-535e-861b130992d9@linux.alibaba.com> (raw)
In-Reply-To: <20220818172322.51705-1-sj@kernel.org>


在 2022/8/19 上午1:23, SeongJae Park 写道:
> Hi Xin,
>
> On Thu, 18 Aug 2022 18:57:32 +0800 Xin Hao <xhao@linux.alibaba.com> wrote:
>
>> The struct of 'damon_lru_sort_ram_walk_arg' is the same with struct of
>> 'damon_addr_range', so, there no need to redefine it, just use struct of
>> 'damon_addr_range' instead.
> Reducing code is always good, thanks.  However, I think the type of the 'start'
> and 'end' fields of 'struct damon_addr_range' might be changed in a future.
OK,  get it.
> It's very unlikely, though.  Also, we might add some more fields to the struct
> in a future.  After all, the purpose of 'struct damon_addr_range' is not saving
> the 'start' and 'end' fields of 'struct resource'.  I'd like to avoid making
> any possible dependency here, sorry.
>
>
> Thanks,
> SJ
>
> [...]

      reply	other threads:[~2022-08-19  2:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18 10:57 [PATCH V2 0/2] mm/damon: A few fixup with lru_sort Xin Hao
2022-08-18 10:57 ` [PATCH V2 1/2] mm/damon/lru_sort: Move target memory region check to head of func Xin Hao
2022-08-18 17:11   ` SeongJae Park
2022-08-19  2:12     ` haoxin
2022-08-19  2:28       ` SeongJae Park
2022-08-19  2:47         ` haoxin
2022-08-19  4:52           ` SeongJae Park
2022-08-18 10:57 ` [PATCH V2 2/2] mm/damon/lru_sort: Remove struct of damon_lru_sort_ram_walk_arg Xin Hao
2022-08-18 17:23   ` SeongJae Park
2022-08-19  1:56     ` haoxin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bc7f671-ad41-6a0c-535e-861b130992d9@linux.alibaba.com \
    --to=xhao@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).