From: Herbert Xu <herbert@gondor.apana.org.au>
To: Saagar Jha <saagar@saagarjha.com>
Cc: dash@vger.kernel.org
Subject: shell: Call CHECK_DECL on stat64
Date: Wed, 26 May 2021 13:49:39 +0800 [thread overview]
Message-ID: <20210526054938.tgkhhh3z5vn2hjyi@gondor.apana.org.au> (raw)
In-Reply-To: <BAE642E9-DFE3-496D-8520-394443D0F24A@saagarjha.com>
Saagar Jha <saagar@saagarjha.com> wrote:
>
> Even though stat64 is not in the public headers, AC_CHECK_FUNC will “find” it because the symbol exists at link time for the test, even though it is not meant to be used. What do you think would be the best way to fix this check on this platform? Would it be preferred to check if the headers contain a declaration of the function?
Yes we should check for a declaration. Does this patch fix the
problem?
---8<---
On macOS it is possible to find stat64 at link-time but not at
compile-time. To make the build process more robust we should
check for the header file as well as the library.
Reported-by: Saagar Jha <saagar@saagarjha.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/configure.ac b/configure.ac
index 44f2f95..466df4c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -140,11 +140,12 @@ if test "$ac_cv_func_signal" != yes; then
fi
dnl Check for stat64 (dietlibc/klibc).
-AC_CHECK_FUNC(stat64,, [
+AC_CHECK_DECL(stat64, AC_CHECK_FUNC(stat64))
+if test "$ac_cv_func_stat64" != yes; then
AC_DEFINE(fstat64, fstat, [64-bit operations are the same as 32-bit])
AC_DEFINE(lstat64, lstat, [64-bit operations are the same as 32-bit])
AC_DEFINE(stat64, stat, [64-bit operations are the same as 32-bit])
-])
+fi
AC_CHECK_FUNC(glob64,, [
AC_DEFINE(glob64_t, glob_t, [64-bit operations are the same as 32-bit])
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2021-05-26 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 8:47 Configure check for stat64 does not work on Apple silicon Saagar Jha
2021-05-26 5:49 ` Herbert Xu [this message]
2021-05-27 8:43 ` shell: Call CHECK_DECL on stat64 Saagar Jha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526054938.tgkhhh3z5vn2hjyi@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dash@vger.kernel.org \
--cc=saagar@saagarjha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).