Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

From: kajoljain <kjain@linux.ibm.com>
To: Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Michael Petlan <mpetlan@redhat.com>,
	Andi Kleen <ak@linux.intel.com>,
	John Garry <john.garry@huawei.com>,
	"Paul A. Clarke" <pc@us.ibm.com>,
	Stephane Eranian <eranian@google.com>,
	Ian Rogers <irogers@google.com>
Subject: Re: [PATCHv3 00/19] perf metric: Add support to reuse metric
Date: Mon, 20 Jul 2020 12:14:00 +0530	[thread overview]
Message-ID: <dbe59791-937d-de95-4ba0-c34e7a1cd273@linux.ibm.com> (raw)
In-Reply-To: <20200719181320.785305-1-jolsa@kernel.org>

On 7/19/20 11:43 PM, Jiri Olsa wrote:
> hi,
> this patchset is adding the support to reused metric in
> another metric.
> 
> For example, to define IPC by using CPI with change like:
> 
>      {
>          "BriefDescription": "Instructions Per Cycle (per Logical Processor)",
> -        "MetricExpr": "INST_RETIRED.ANY / CPU_CLK_UNHALTED.THREAD",
> +        "MetricExpr": "1/CPI",
>          "MetricGroup": "TopDownL1",
>          "MetricName": "IPC"
>      },
> 
> I won't be able to find all the possible places we could
> use this at, so I wonder you guys (who was asking for this)
> would try it and come up with comments if there's something
> missing or we could already use it at some places.
> 
> It's based on Arnaldo's tmp.perf/core.
> 
> v3 changes:
>   - added some acks
>   - some patches got merged
>   - added missing zalloc include [John Garry]
>   - added ids array outside the egroup object [Ian]
>   - removed wrong m->has_constraint assignment [Ian]
>   - renamed 'list' to 'metric_list' [Ian]
>   - fixed group metric and added test for it [Paul A. Clarke]
>   - fixed memory leak [Arnaldo]
>   - using lowercase keys for metrics in hashmap, because jevents
>     converts metric_expr to lowercase
> 
> Also available in here:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/metric
> 

Hi Jiri,
   I am trying to review these patches and also test it in power box. I am testing your `perf/metric` branch.
With your current patches,some of hv-24x7 events not giving appropriate result
while doing "--metric-only" command. I can't see corresponding output for all chips.

This is output on power9 machine:

Without your patches on upstream kernel:

command# ./perf stat --metric-only -M PowerBUS_Frequency -I 1000 -C 0
#           time GHz  PowerBUS_Frequency_0 GHz  PowerBUS_Frequency_1 
     1.000073877                        2.0                        2.0 
     2.000240551                        2.0                        1.9 
^C     2.452590532                        0.9                        0.9 

 Performance counter stats for 'CPU(s) 0':

                       4.8                        4.8 

       2.452654834 seconds time elapsed

With your patches on perf/metric branch:

command# ./perf stat --metric-only -M PowerBUS_Frequency -I 1000 -C 0
assertion failed at util/metricgroup.c:709
#           time GHz  PowerBUS_Frequency_0 
     1.000073875                        2.0 
     2.000380706                        2.0 
^C     2.658962182                        1.3 

 Performance counter stats for 'CPU(s) 0':

                       5.2 

Please let me know, if I am missing something. 

Thanks,
Kajol Jain

> thanks,
> jirka
> 
> 
> ---
> Jiri Olsa (19):
>       perf metric: Fix memory leak in expr__add_id function
>       perf metric: Add expr__add_id function
>       perf metric: Change expr__get_id to return struct expr_id_data
>       perf metric: Add expr__del_id function
>       perf metric: Add macros for iterating map events
>       perf metric: Add add_metric function
>       perf metric: Rename __metricgroup__add_metric to __add_metric
>       perf metric: Collect referenced metrics in struct metric_ref_node
>       perf metric: Collect referenced metrics in struct metric_expr
>       perf metric: Add referenced metrics to hash data
>       perf metric: Compute referenced metrics
>       perf metric: Add events for the current list
>       perf metric: Add cache_miss_cycles to metric parse test
>       perf metric: Add DCache_L2 to metric parse test
>       perf metric: Add recursion check when processing nested metrics
>       perf metric: Make compute_single function more precise
>       perf metric: Add metric group test
>       perf metric: Rename struct egroup to metric
>       perf metric: Rename group_list to metric_list
> 
>  tools/perf/tests/parse-metric.c | 206 +++++++++++++++++++++++++++++++++++++++++++++++++----
>  tools/perf/util/expr.c          | 143 ++++++++++++++++++++++++++++++++-----
>  tools/perf/util/expr.h          |  30 +++++++-
>  tools/perf/util/expr.y          |  16 +++--
>  tools/perf/util/metricgroup.c   | 466 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------
>  tools/perf/util/metricgroup.h   |   6 ++
>  tools/perf/util/stat-shadow.c   |  20 ++++--
>  7 files changed, 751 insertions(+), 136 deletions(-)
> 