From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Song Liu <song@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Richard Weinberger <richard@nod.at>,
Minchan Kim <minchan@kernel.org>,
linux-mtd@lists.infradead.org, dm-devel@redhat.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH 10/12] bdi: replace BDI_CAP_STABLE_WRITES with a queue and a sb flag
Date: Thu, 17 Sep 2020 11:25:24 +0200 [thread overview]
Message-ID: <20200917092524.GC7347@quack2.suse.cz> (raw)
In-Reply-To: <20200910144833.742260-11-hch@lst.de>
On Thu 10-09-20 16:48:30, Christoph Hellwig wrote:
> The BDI_CAP_STABLE_WRITES is one of the few bits of information in the
> backing_dev_info shared between the block drivers and the writeback code.
> To help untangling the dependency replace it with a queue flag and a
> superblock flag derived from it. This also helps with the case of e.g.
> a file system requiring stable writes due to its own checksumming, but
> not forcing it on other users of the block device like the swap code.
>
> One downside is that we can't support the stable_pages_required bdi
> attribute in sysfs anymore. It is replaced with a queue attribute, that
> can also be made writable for easier testing.
^^^^^^^^^^^^^^^^
is also made
For a while I was confused thinking that the new attribute is not writeable
but when I checked the code I saw that it is.
Not supporting stable_pages_required attribute is not nice but probably it
isn't widely used. Maybe the deprecation message can even mention to use
the queue attribute? Otherwise the patch looks good to me so feel free to
add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-09-17 9:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 14:48 bdi cleanups v4 Christoph Hellwig
[not found] ` <20200910144833.742260-1-hch-jcswGhMUV9g@public.gmane.org>
2020-09-10 14:48 ` [PATCH 01/12] fs: remove the unused SB_I_MULTIROOT flag Christoph Hellwig
2020-09-17 9:41 ` Jan Kara
2020-09-10 14:48 ` [PATCH 02/12] drbd: remove dead code in device_to_statistics Christoph Hellwig
[not found] ` <20200910144833.742260-3-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 9:46 ` Jan Kara
2020-09-10 14:48 ` [PATCH 03/12] drbd: remove RB_CONGESTED_REMOTE Christoph Hellwig
2020-09-17 9:55 ` Jan Kara
[not found] ` <20200917095507.GJ7347-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2020-09-19 6:58 ` Christoph Hellwig
2020-09-10 14:48 ` [PATCH 04/12] bdi: initialize ->ra_pages and ->io_pages in bdi_init Christoph Hellwig
[not found] ` <20200910144833.742260-5-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 10:04 ` Jan Kara
2020-09-19 7:01 ` Christoph Hellwig
2020-09-10 14:48 ` [PATCH 07/12] bdi: remove BDI_CAP_CGROUP_WRITEBACK Christoph Hellwig
[not found] ` <20200910144833.742260-8-hch-jcswGhMUV9g@public.gmane.org>
2020-09-16 9:28 ` David Sterba
2020-09-17 9:36 ` Jan Kara
2020-09-10 14:48 ` [PATCH 09/12] mm: use SWP_SYNCHRONOUS_IO more intelligently Christoph Hellwig
2020-09-17 9:06 ` Jan Kara
2020-09-10 14:48 ` [PATCH 11/12] bdi: invert BDI_CAP_NO_ACCT_WB Christoph Hellwig
[not found] ` <20200910144833.742260-12-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 9:27 ` Jan Kara
2020-09-10 14:48 ` [PATCH 12/12] bdi: replace BDI_CAP_NO_{WRITEBACK, ACCT_DIRTY} with a single flag Christoph Hellwig
[not found] ` <20200910144833.742260-13-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 9:31 ` Jan Kara
2020-09-10 14:48 ` [PATCH 05/12] md: update the optimal I/O size on reshape Christoph Hellwig
2020-09-12 6:17 ` Song Liu
2020-09-10 14:48 ` [PATCH 06/12] block: lift setting the readahead size into the block layer Christoph Hellwig
[not found] ` <20200910144833.742260-7-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 10:35 ` Jan Kara
2020-09-19 7:31 ` Christoph Hellwig
2020-09-10 14:48 ` [PATCH 08/12] bdi: remove BDI_CAP_SYNCHRONOUS_IO Christoph Hellwig
[not found] ` <20200910144833.742260-9-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 9:36 ` Jan Kara
2020-09-10 14:48 ` [PATCH 10/12] bdi: replace BDI_CAP_STABLE_WRITES with a queue and a sb flag Christoph Hellwig
2020-09-17 9:25 ` Jan Kara [this message]
[not found] ` <20200917092524.GC7347-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2020-09-19 6:51 ` Christoph Hellwig
2020-09-15 15:18 bdi cleanups v5 Christoph Hellwig
[not found] ` <20200915151829.1767176-1-hch-jcswGhMUV9g@public.gmane.org>
2020-09-15 15:18 ` [PATCH 10/12] bdi: replace BDI_CAP_STABLE_WRITES with a queue and a sb flag Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917092524.GC7347@quack2.suse.cz \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@lst.de \
--cc=hdegoede@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=richard@nod.at \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).