[dm-devel] [PATCH 4/4] dm era: Remove unreachable resize operation in pre-resume function

From: Nikos Tsironis <ntsironis@arrikto.com>
To: snitzer@redhat.com, agk@redhat.com, dm-devel@redhat.com
Cc: ejt@redhat.com, ntsironis@arrikto.com
Subject: [dm-devel] [PATCH 4/4] dm era: Remove unreachable resize operation in pre-resume function
Date: Fri, 22 Jan 2021 17:25:56 +0200	[thread overview]
Message-ID: <20210122152556.24822-5-ntsironis@arrikto.com> (raw)
In-Reply-To: <20210122152556.24822-1-ntsironis@arrikto.com>

The device metadata are resized in era_ctr(), so the metadata resize
operation in era_preresume() never runs.

Also, note, that if the operation did ever run it would deadlock, since
the worker has not been started at this point.

Fixes: eec40579d84873 ("dm: add era target")
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: Nikos Tsironis <ntsironis@arrikto.com>
---
 drivers/md/dm-era-target.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/md/dm-era-target.c b/drivers/md/dm-era-target.c
index 104fb110cd4e..c40e132e50cd 100644
--- a/drivers/md/dm-era-target.c
+++ b/drivers/md/dm-era-target.c
@@ -1567,15 +1567,6 @@ static int era_preresume(struct dm_target *ti)
 {
 	int r;
 	struct era *era = ti->private;
-	dm_block_t new_size = calc_nr_blocks(era);
-
-	if (era->nr_blocks != new_size) {
-		r = in_worker1(era, metadata_resize, &new_size);
-		if (r)
-			return r;
-
-		era->nr_blocks = new_size;
-	}
 
 	start_worker(era);
 
-- 
2.11.0

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

