From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9596FC433F5 for ; Wed, 15 Sep 2021 23:48:56 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FB10603E9 for ; Wed, 15 Sep 2021 23:48:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2FB10603E9 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631749735; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=YSkbxuOnRGVC7YeS2OvNT8y6UrBf0pNonG2HCL3X4GM=; b=Q4J5HYaIDd37DeF+uTWNg09HY4qzOCA4JRaFV+1aVTQ8g6TTTAIYAbgh7ORG7w61RQzqDD xBcaECZRgb4k35vKmffcSbEj/eiqXWD/IX6te7FtARYw4faZ2+HORzvuv65ilT3D5LKbCC 3SHwV9vQodU7IHpHEo8q1nDV5eYaO7s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-FkI8KM7ZNGKE6O7RgPotWw-1; Wed, 15 Sep 2021 19:48:53 -0400 X-MC-Unique: FkI8KM7ZNGKE6O7RgPotWw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D8EB1006AA0; Wed, 15 Sep 2021 23:48:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 758EA5453A; Wed, 15 Sep 2021 23:48:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3A77E4E58F; Wed, 15 Sep 2021 23:48:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18FNeGiG014242 for ; Wed, 15 Sep 2021 19:40:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 062027A8CB; Wed, 15 Sep 2021 23:40:16 +0000 (UTC) Received: from octiron.msp.redhat.com (unknown [10.15.80.209]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC77877BF5; Wed, 15 Sep 2021 23:40:11 +0000 (UTC) Received: from octiron.msp.redhat.com (localhost.localdomain [127.0.0.1]) by octiron.msp.redhat.com (8.14.9/8.14.9) with ESMTP id 18FNe9X9006647; Wed, 15 Sep 2021 18:40:10 -0500 Received: (from bmarzins@localhost) by octiron.msp.redhat.com (8.14.9/8.14.9/Submit) id 18FNe9iw006646; Wed, 15 Sep 2021 18:40:09 -0500 Date: Wed, 15 Sep 2021 18:40:08 -0500 From: Benjamin Marzinski To: mwilck@suse.com Message-ID: <20210915234008.GU3087@octiron.msp.redhat.com> References: <20210910114120.13665-1-mwilck@suse.com> <20210910114120.13665-10-mwilck@suse.com> MIME-Version: 1.0 In-Reply-To: <20210910114120.13665-10-mwilck@suse.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: dm-devel@redhat.com Cc: lixiaokeng@huawei.com, dm-devel@redhat.com, Chongyun Wu Subject: Re: [dm-devel] [PATCH 09/35] multipathd: cli_del_map: fix reply for delayed action X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Sep 10, 2021 at 01:40:54PM +0200, mwilck@suse.com wrote: > From: Martin Wilck > > Return code 2 from ev_remove_map means that a delayed remove has > been started, which is not the same as failure. > Reviewed-by: Benjamin Marzinski > Signed-off-by: Martin Wilck > --- > multipathd/cli_handlers.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/multipathd/cli_handlers.c b/multipathd/cli_handlers.c > index 44f76ee..2e4b239 100644 > --- a/multipathd/cli_handlers.c > +++ b/multipathd/cli_handlers.c > @@ -783,6 +783,9 @@ cli_del_map (void * v, char ** reply, int * len, void * data) > return 1; > } > rc = ev_remove_map(param, alias, minor, vecs); > + if (rc == 2) > + *reply = strdup("delayed"); > + > FREE(alias); > return rc; > } > -- > 2.33.0 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel