From: Benjamin Marzinski <bmarzins@redhat.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@lists.linux.dev>,
Martin Wilck <Martin.Wilck@suse.com>
Subject: [PATCH v2 3/5] libmultipath: remove redundant config option from InfiniBox config
Date: Thu, 25 Apr 2024 19:35:15 -0400 [thread overview]
Message-ID: <20240425233517.2125142-4-bmarzins@redhat.com> (raw)
In-Reply-To: <20240425233517.2125142-1-bmarzins@redhat.com>
The InfiniBox config already sets no_path_retry to "fail", so it won't
ever queue IO. That means setting flush_on_last_del to "always" is
redundant, since queueing is always disabled. Remove the
flush_on_last_del parameter, to make it easier for users to override the
default behavior if desired.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
libmultipath/hwtable.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index ce600030..51b15eab 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1160,7 +1160,6 @@ static struct hwentry default_hw[] = {
.no_path_retry = NO_PATH_RETRY_FAIL,
.minio = 1,
.minio_rq = 1,
- .flush_on_last_del = FLUSH_ALWAYS,
.fast_io_fail = 15,
},
/*
--
2.43.0
next prev parent reply other threads:[~2024-04-25 23:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 23:35 [PATCH v2 0/5] multipath: fix hang in flush_map_nopaths Benjamin Marzinski
2024-04-25 23:35 ` [PATCH v2 1/5] libmultipath: export partmap_in_use Benjamin Marzinski
2024-04-25 23:35 ` [PATCH v2 2/5] libmultipath: change flush_on_last_del to fix a multipathd hang Benjamin Marzinski
2024-04-30 17:06 ` Martin Wilck
2024-04-30 21:29 ` Benjamin Marzinski
2024-05-02 8:36 ` Martin Wilck
2024-05-02 15:06 ` Martin Wilck
2024-04-25 23:35 ` Benjamin Marzinski [this message]
2024-04-25 23:35 ` [PATCH v2 4/5] libmultipath: pad dev_loss_tmo to avoid race with no_path_retry Benjamin Marzinski
2024-05-02 15:14 ` Martin Wilck
2024-05-02 16:05 ` Benjamin Marzinski
2024-05-02 18:44 ` Martin Wilck
2024-04-25 23:35 ` [PATCH v2 5/5] libmultipath: fix deferred_remove function arguments Benjamin Marzinski
2024-05-02 15:52 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425233517.2125142-4-bmarzins@redhat.com \
--to=bmarzins@redhat.com \
--cc=Martin.Wilck@suse.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).