From: Robin Gong <yibin.gong@nxp.com>
To: "vkoul@kernel.org" <vkoul@kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Subject: Re: [PATCH v3 5/8] dmaengine: fsl-edma: add drvdata for vf610
Date: Wed, 5 Jun 2019 02:25:02 +0000 [thread overview]
Message-ID: <1559730524.24019.11.camel@nxp.com> (raw)
In-Reply-To: <20190604123331.GE15118@vkoul-mobl>
On 二, 2019-06-04 at 18:03 +0530, Vinod Koul wrote:
> On 29-05-19, 17:08, yibin.gong@nxp.com wrote:
>
> >
> > @@ -205,8 +228,9 @@ static int fsl_edma_probe(struct
> > platform_device *pdev)
> > if (!fsl_edma)
> > return -ENOMEM;
> >
> > - fsl_edma->version = v1;
> > - fsl_edma->dmamux_nr = DMAMUX_NR;
> > + fsl_edma->drvdata = drvdata;
> > + fsl_edma->version = drvdata->version;
> > + fsl_edma->dmamux_nr = drvdata->dmamuxs;
> And can we avoid the duplication here, you have version and dmamuxs
> represented in two places. But right now it looks logical so the
> removal
> should be done after this series
To avoid more code changes in other edma driver such as mcf-edma.c and
fsl-edma-common.c(replace all version/dmamux_nr with new
'drvdata'),meanwhile, no board to test mcf-edma so I keep
'version'/'dmamux' here in the last minute. But if you stick, I would
try to refine it in next version.
>
next prev parent reply other threads:[~2019-06-05 2:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 9:08 [PATCH v3 0/8] add edma2 for i.mx7ulp yibin.gong
2019-05-29 9:08 ` [PATCH v3 1/8] dmaengine: fsl-edma: add dmamux_nr for next version yibin.gong
2019-05-29 9:08 ` [PATCH v3 2/8] dmaengine: mcf-edma: update to 'dmamux_nr' yibin.gong
2019-05-29 9:08 ` [PATCH v3 3/8] dmaengine: fsl-edma-common: move dmamux register to another single function yibin.gong
2019-05-29 9:08 ` [PATCH v3 4/8] dmaengine: fsl-edma-common: version check for v2 instead yibin.gong
2019-05-29 9:08 ` [PATCH v3 5/8] dmaengine: fsl-edma: add drvdata for vf610 yibin.gong
2019-06-04 12:33 ` Vinod Koul
2019-06-05 2:25 ` Robin Gong [this message]
2019-05-29 9:08 ` [PATCH v3 6/8] dt-bindings: dma: fsl-edma: add new i.mx7ulp-edma yibin.gong
2019-05-29 9:08 ` [PATCH v3 7/8] dmaengine: fsl-edma: add i.mx7ulp edma2 version support yibin.gong
2019-06-04 12:37 ` Vinod Koul
2019-06-05 2:29 ` Robin Gong
2019-05-29 9:08 ` [PATCH v3 8/8] ARM: dts: imx7ulp: add edma device node yibin.gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559730524.24019.11.camel@nxp.com \
--to=yibin.gong@nxp.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).