dmaengine.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: vkoul@kernel.org
Cc: dmaengine@vger.kernel.org
Subject: [PATCH] dmaengine: idxd: fix missing symbol for pci_msi_mask_irq()
Date: Tue, 07 Jul 2020 09:24:52 -0700	[thread overview]
Message-ID: <159413909204.59019.6521464735007914513.stgit@djiang5-desk3.ch.intel.com> (raw)

lkp report compile issue without CONFIG_PCI_MSI_IRQ_DOMAIN being set. Add
dependency to the driver to ensure symbol is valid.

   ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
>> drivers/dma/idxd/device.c:24: undefined reference to `pci_msi_mask_irq'
   ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
>> drivers/dma/idxd/device.c:41: undefined reference to `pci_msi_unmask_irq'

Fixes: 3592633e52d2 ("dmaengine: idxd: move idxd interrupt handling to mask instead of ignore")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/dma/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index b70e90765ad3..cd89fe38834b 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -286,6 +286,7 @@ config INTEL_IDXD
 	tristate "Intel Data Accelerators support"
 	depends on PCI && X86_64
 	depends on SBITMAP
+	depends on PCI_MSI_IRQ_DOMAIN
 	select DMA_ENGINE
 	help
 	  Enable support for the Intel(R) data accelerators present


                 reply	other threads:[~2020-07-07 16:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159413909204.59019.6521464735007914513.stgit@djiang5-desk3.ch.intel.com \
    --to=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).