From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Vinod Koul <vkoul@kernel.org>
Cc: devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH 1/3] dt-bindings: dma: Add YAML schemas for the generic DMA bindings
Date: Sat, 20 Jul 2019 11:24:21 +0200 [thread overview]
Message-ID: <20190720092421.bqbsyrk3atejqgsf@flea> (raw)
In-Reply-To: <20190720064123.15411-1-maxime.ripard@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 2286 bytes --]
On Sat, Jul 20, 2019 at 08:41:21AM +0200, Maxime Ripard wrote:
> The DMA controllers and consumers have a bunch of generic properties that
> are needed in a device tree. Add a YAML schemas for those.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> ---
>
> Changes from v1:
> - Dropped the dma consumer schemas
> - Fixed the node name of the examples
> - Enhanced a bit the description for dma-requests in case of a router
> - Split the bindings in two to handle the router and controller case
> separately
> - Made #dma-cells required
> ---
> .../devicetree/bindings/dma/dma-common.yaml | 43 +++++++
> .../bindings/dma/dma-controller.yaml | 35 ++++++
> .../devicetree/bindings/dma/dma-router.yaml | 50 ++++++++
> Documentation/devicetree/bindings/dma/dma.txt | 114 +-----------------
> 4 files changed, 129 insertions(+), 113 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/dma/dma-common.yaml
> create mode 100644 Documentation/devicetree/bindings/dma/dma-controller.yaml
> create mode 100644 Documentation/devicetree/bindings/dma/dma-router.yaml
>
> diff --git a/Documentation/devicetree/bindings/dma/dma-common.yaml b/Documentation/devicetree/bindings/dma/dma-common.yaml
> new file mode 100644
> index 000000000000..422fd6c8b0ce
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/dma-common.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/dma-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: DMA Engine Generic Binding
> +
> +maintainers:
> + - Vinod Koul <vkoul@kernel.org>
> +
> +description:
> + Generic binding to provide a way for a driver using DMA Engine to
> + retrieve the DMA request or channel information that goes from a
> + hardware device to a DMA controller.
> +
> +properties:
> + "#dma-cells":
> + minimum: 1
> + # Should be enough
> + maximum: 255
> + description:
> + Used to provide DMA controller specific information.
We need a select statement here, otherwise it will try to validate
every node and report dma-cells as missing. I'll send a v3.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-07-20 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-20 6:41 [PATCH 1/3] dt-bindings: dma: Add YAML schemas for the generic DMA bindings Maxime Ripard
2019-07-20 6:41 ` [PATCH 2/3] dt-bindings: dma: Convert Allwinner A10 DMA to a schema Maxime Ripard
2019-07-20 6:41 ` [PATCH 3/3] dt-bindings: dma: Convert Allwinner A31 and A64 " Maxime Ripard
2019-07-20 9:24 ` Maxime Ripard [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-07-11 9:21 [PATCH 1/3] dt-bindings: dma: Add YAML schemas for the generic DMA bindings Maxime Ripard
2019-07-11 17:33 ` Rob Herring
2019-07-12 21:27 ` Peter Ujfalusi
2019-07-12 21:49 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190720092421.bqbsyrk3atejqgsf@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).