From: Vinod Koul <vkoul@kernel.org>
To: Satendra Singh Thakur <sst2005@gmail.com>
Cc: Jun Nie <jun.nie@linaro.org>, Shawn Guo <shawnguo@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma/zx/remove: Removed dmam_pool_destroy from remove method
Date: Tue, 5 Nov 2019 22:28:55 +0530 [thread overview]
Message-ID: <20191105165855.GC952516@vkoul-mobl> (raw)
In-Reply-To: <20191024041623.24658-1-sst2005@gmail.com>
On 24-10-19, 09:46, Satendra Singh Thakur wrote:
> In the probe method dmam_pool_create is used. Therefore, there is no
> need to explicitly call dmam_pool_destroy in remove method as this
> will be automatically taken care by devres
Please do not reinvent system tags, git log is your friend to check for
the tags to be used.
In this case, it is dmaengine: zx: remove ...
>
> Signed-off-by: Satendra Singh Thakur <sst2005@gmail.com>
> ---
> drivers/dma/zx_dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/zx_dma.c b/drivers/dma/zx_dma.c
> index 9f4436f7c914..7e4e457ac6d5 100644
> --- a/drivers/dma/zx_dma.c
> +++ b/drivers/dma/zx_dma.c
> @@ -894,7 +894,6 @@ static int zx_dma_remove(struct platform_device *op)
> list_del(&c->vc.chan.device_node);
> }
> clk_disable_unprepare(d->clk);
> - dmam_pool_destroy(d->pool);
>
> return 0;
> }
> --
> 2.17.1
--
~Vinod
next prev parent reply other threads:[~2019-11-05 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 4:16 [PATCH] dma/zx/remove: Removed dmam_pool_destroy from remove method Satendra Singh Thakur
2019-11-05 16:58 ` Vinod Koul [this message]
2019-11-09 11:36 ` [PATCH v1] dmaengine: zx: remove: removed dmam_pool_destroy Satendra Singh Thakur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105165855.GC952516@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jun.nie@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=sst2005@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).