From: Vinod Koul <vkoul@kernel.org>
To: Sebastian von Ohr <vonohr@smaract.com>
Cc: dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: xilinx_dma: Add missing check for empty list
Date: Wed, 15 Apr 2020 21:42:43 +0530 [thread overview]
Message-ID: <20200415161243.GY72691@vkoul-mobl> (raw)
In-Reply-To: <20200303130518.333-1-vonohr@smaract.com>
On 03-03-20, 14:05, Sebastian von Ohr wrote:
> The DMA transfer might finish just after checking the state with
> dma_cookie_status, but before the lock is acquired. Not checking
> for an empty list in xilinx_dma_tx_status may result in reading
> random data or data corruption when desc is written to. This can
> be reliably triggered by using dma_sync_wait to wait for DMA
> completion.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2020-04-15 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 13:05 [PATCH] dmaengine: xilinx_dma: Add missing check for empty list Sebastian von Ohr
2020-03-06 13:34 ` Vinod Koul
2020-03-06 13:57 ` Radhey Shyam Pandey
2020-03-11 9:16 ` Vinod Koul
2020-04-07 7:52 ` Sebastian von Ohr
2020-04-07 16:03 ` Radhey Shyam Pandey
2020-04-08 7:12 ` Sebastian von Ohr
2020-04-08 14:06 ` Radhey Shyam Pandey
2020-04-08 15:19 ` Sebastian von Ohr
2020-04-09 7:40 ` Radhey Shyam Pandey
2020-04-15 16:12 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415161243.GY72691@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=vonohr@smaract.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).