Re: [PATCH v2] dmaengine: cookie bypass for out of order completion

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2911 bytes --]

Hi Dave,

I love your patch! Yet something to improve:

[auto build test ERROR on slave-dma/next]
[also build test ERROR on linus/master v5.7-rc4 next-20200505]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Dave-Jiang/dmaengine-cookie-bypass-for-out-of-order-completion/20200506-115734
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git next
config: x86_64-randconfig-a003-20200506 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/dma/idxd/dma.c:9:0:
   drivers/dma/idxd/dma.c: In function 'idxd_register_dma_device':
>> drivers/dma/idxd/dma.c:177:14: error: 'DMA_NO_COMPLETION_ORDER' undeclared (first use in this function); did you mean 'DMA_COMPLETION_NO_ORDER'?
     dma_cap_set(DMA_NO_COMPLETION_ORDER, dma->cap_mask);
                 ^
   include/linux/dmaengine.h:1334:46: note: in definition of macro 'dma_cap_set'
    #define dma_cap_set(tx, mask) __dma_cap_set((tx), &(mask))
                                                 ^~
   drivers/dma/idxd/dma.c:177:14: note: each undeclared identifier is reported only once for each function it appears in
     dma_cap_set(DMA_NO_COMPLETION_ORDER, dma->cap_mask);
                 ^
   include/linux/dmaengine.h:1334:46: note: in definition of macro 'dma_cap_set'
    #define dma_cap_set(tx, mask) __dma_cap_set((tx), &(mask))
                                                 ^~

vim +177 drivers/dma/idxd/dma.c

   169	
   170	int idxd_register_dma_device(struct idxd_device *idxd)
   171	{
   172		struct dma_device *dma = &idxd->dma_dev;
   173	
   174		INIT_LIST_HEAD(&dma->channels);
   175		dma->dev = &idxd->pdev->dev;
   176	
 > 177		dma_cap_set(DMA_NO_COMPLETION_ORDER, dma->cap_mask);
   178		dma->device_release = idxd_dma_release;
   179	
   180		if (idxd->hw.opcap.bits[0] & IDXD_OPCAP_MEMMOVE) {
   181			dma_cap_set(DMA_MEMCPY, dma->cap_mask);
   182			dma->device_prep_dma_memcpy = idxd_dma_submit_memcpy;
   183		}
   184	
   185		dma->device_tx_status = idxd_dma_tx_status;
   186		dma->device_issue_pending = idxd_dma_issue_pending;
   187		dma->device_alloc_chan_resources = idxd_dma_alloc_chan_resources;
   188		dma->device_free_chan_resources = idxd_dma_free_chan_resources;
   189	
   190		return dma_async_device_register(&idxd->dma_dev);
   191	}
   192	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33720 bytes --]