From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org,
alsa-devel@alsa-project.org, Hyun Kwon <hyun.kwon@xilinx.com>,
Randy Dunlap <rdunlap@infradead.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Alexandre Bounine <alex.bou9@gmail.com>,
Mark Brown <broonie@kernel.org>,
Matt Porter <mporter@kernel.crashing.org>
Subject: Re: [PATCH v2 0/3] Fix Kconfig dependency issue with DMAENGINES selection
Date: Fri, 31 Jul 2020 23:42:06 +0300 [thread overview]
Message-ID: <20200731204206.GC24315@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200731164744.GF12965@vkoul-mobl>
Hi Vinod,
On Fri, Jul 31, 2020 at 10:17:44PM +0530, Vinod Koul wrote:
> On 31-07-20, 18:24, Laurent Pinchart wrote:
> > Hello,
> >
> > This small series fixes a Kconfig dependency issue with the recently
> > merged Xilixn DPSUB DRM/KMS driver. The fix is in patch 3/3, but
> > requires a separate fixes in patches 1/3 and 2/3 to avoid circular
> > dependencies:
> >
> > drivers/i2c/Kconfig:8:error: recursive dependency detected!
> > drivers/i2c/Kconfig:8: symbol I2C is selected by FB_DDC
> > drivers/video/fbdev/Kconfig:63: symbol FB_DDC depends on FB
> > drivers/video/fbdev/Kconfig:12: symbol FB is selected by DRM_KMS_FB_HELPER
> > drivers/gpu/drm/Kconfig:80: symbol DRM_KMS_FB_HELPER depends on DRM_KMS_HELPER
> > drivers/gpu/drm/Kconfig:74: symbol DRM_KMS_HELPER is selected by DRM_ZYNQMP_DPSUB
> > drivers/gpu/drm/xlnx/Kconfig:1: symbol DRM_ZYNQMP_DPSUB depends on DMA_ENGINE
> > drivers/dma/Kconfig:44: symbol DMA_ENGINE depends on DMADEVICES
> > drivers/dma/Kconfig:6: symbol DMADEVICES is selected by SND_SOC_SH4_SIU
> > sound/soc/sh/Kconfig:30: symbol SND_SOC_SH4_SIU is selected by SND_SIU_MIGOR
> > sound/soc/sh/Kconfig:60: symbol SND_SIU_MIGOR depends on I2C
> > For a resolution refer to Documentation/kbuild/kconfig-language.rst
> > subsection "Kconfig recursive dependency limitations"
> >
> > Due to the DPSUB driver being merged in v5.9, this is a candidate fix
> > for v5.9 as well. 1/3 and 2/3 can be merged independently, 3/3 depends
> > on the first two. What's the best course of action, can I merge this all
> > in a single tree, or should the rapidio and ASoC patches be merged
> > independently early in the -rc cycle, and the DRM patch later on top ? I
> > don't expect conflicts (especially in 2/3 and 3/3), so merging the whole
> > series in one go would be simpler in my opinion.
>
> Acked-By: Vinod Koul <vkoul@kernel.org>
Thank you.
As Mark as queued the sound fix in his for-next branch for v5.9, could
you queue the dmaengine fix for v5.9 too ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-07-31 20:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 15:24 [PATCH v2 0/3] Fix Kconfig dependency issue with DMAENGINES selection Laurent Pinchart
2020-07-31 15:24 ` [PATCH v2 1/3] rapidio: Replace 'select' DMADEVICES 'with depends on' Laurent Pinchart
2020-07-31 15:24 ` [PATCH v2 2/3] ASoC: sh: " Laurent Pinchart
2020-07-31 15:24 ` [PATCH v2 3/3] drm: xlnx: dpsub: Fix DMADEVICES Kconfig dependency Laurent Pinchart
2020-07-31 16:47 ` [PATCH v2 0/3] Fix Kconfig dependency issue with DMAENGINES selection Vinod Koul
2020-07-31 20:42 ` Laurent Pinchart [this message]
2020-08-02 6:44 ` Vinod Koul
2020-08-11 22:52 ` Laurent Pinchart
2020-08-12 3:59 ` Vinod Koul
2020-08-19 0:10 ` Laurent Pinchart
2020-07-31 18:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731204206.GC24315@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=alex.bou9@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hyun.kwon@xilinx.com \
--cc=lgirdwood@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=mporter@kernel.crashing.org \
--cc=rdunlap@infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).