From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Sinan Kaya <okaya@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Vinod Koul <vkoul@kernel.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dmaengine: qcom: Drop hidma DT support
Date: Tue, 23 Apr 2024 18:23:08 +0200 [thread overview]
Message-ID: <2efd6856-0e20-4b0f-93d3-60926ba2e4f3@linaro.org> (raw)
In-Reply-To: <20240423161413.481670-1-robh@kernel.org>
On 4/23/24 18:14, Rob Herring (Arm) wrote:
> The DT support in hidma has been broken since commit 37fa4905d22a
> ("dmaengine: qcom_hidma: simplify DT resource parsing") in 2018. The
> issue is the of_address_to_resource() calls bail out on success rather
> than failure. This driver is for a defunct QCom server platform where
> DT use was limited to start with. As it seems no one has noticed the
> breakage, just remove the DT support altogether.
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2024-04-23 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 16:14 [PATCH 1/2] dmaengine: qcom: Drop hidma DT support Rob Herring (Arm)
2024-04-23 16:14 ` [PATCH 2/2] dt-bindings: dma: Drop unused QCom hidma binding Rob Herring (Arm)
2024-04-23 16:22 ` Konrad Dybcio
2024-04-23 16:25 ` Jeffrey Hugo
2024-04-23 16:23 ` Konrad Dybcio [this message]
2024-04-23 16:24 ` [PATCH 1/2] dmaengine: qcom: Drop hidma DT support Jeffrey Hugo
[not found] ` <22adec0d-3b20-40f4-9ced-72d7cd48c968@gmail.com>
2024-04-24 6:22 ` Dan Carpenter
2024-04-25 9:17 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2efd6856-0e20-4b0f-93d3-60926ba2e4f3@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).