From: Dave Jiang <dave.jiang@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Fix error handling in idxd_wq_cdev_dev_setup()
Date: Wed, 5 Feb 2020 09:32:04 -0700 [thread overview]
Message-ID: <34f96682-a9c4-ee41-5bbb-320025b7d632@intel.com> (raw)
In-Reply-To: <20200205123248.hmtog7qa2eiqaagh@kili.mountain>
On 2/5/20 5:32 AM, Dan Carpenter wrote:
> We can't call kfree(dev) after calling device_register(dev). The "dev"
> pointer has to be freed using put_device().
>
> Fixes: 42d279f9137a ("dmaengine: idxd: add char driver to expose submission portal to userland")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/idxd/cdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
> index 1d7347825b95..df47be612ebb 100644
> --- a/drivers/dma/idxd/cdev.c
> +++ b/drivers/dma/idxd/cdev.c
> @@ -204,6 +204,7 @@ static int idxd_wq_cdev_dev_setup(struct idxd_wq *wq)
> minor = ida_simple_get(&cdev_ctx->minor_ida, 0, MINORMASK, GFP_KERNEL);
> if (minor < 0) {
> rc = minor;
> + kfree(dev);
> goto ida_err;
> }
>
> @@ -212,7 +213,6 @@ static int idxd_wq_cdev_dev_setup(struct idxd_wq *wq)
> rc = device_register(dev);
> if (rc < 0) {
> dev_err(&idxd->pdev->dev, "device register failed\n");
> - put_device(dev);
> goto dev_reg_err;
> }
> idxd_cdev->minor = minor;
> @@ -221,8 +221,8 @@ static int idxd_wq_cdev_dev_setup(struct idxd_wq *wq)
>
> dev_reg_err:
> ida_simple_remove(&cdev_ctx->minor_ida, MINOR(dev->devt));
> + put_device(dev);
> ida_err:
> - kfree(dev);
> idxd_cdev->dev = NULL;
> return rc;
> }
>
next prev parent reply other threads:[~2020-02-05 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 12:32 [PATCH] dmaengine: idxd: Fix error handling in idxd_wq_cdev_dev_setup() Dan Carpenter
2020-02-05 16:32 ` Dave Jiang [this message]
2020-02-13 15:07 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34f96682-a9c4-ee41-5bbb-320025b7d632@intel.com \
--to=dave.jiang@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).