From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Barry Song <song.bao.hua@hisilicon.com>
Cc: <vkoul@kernel.org>, <dmaengine@vger.kernel.org>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: Re: [PATCH 10/10] dmaengine: pxa_dma: remove redundant irqsave and irqrestore in hardIRQ
Date: Fri, 23 Oct 2020 22:16:55 +0200 [thread overview]
Message-ID: <87sga4wvd4.fsf@belgarion.home> (raw)
In-Reply-To: <20201015235921.21224-11-song.bao.hua@hisilicon.com> (Barry Song's message of "Fri, 16 Oct 2020 12:59:21 +1300")
Barry Song <song.bao.hua@hisilicon.com> writes:
> Running in hardIRQ, disabling IRQ is redundant.
>
> Cc: Daniel Mack <daniel@zonque.org>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Why not.
I would have liked a longer commit message to explain the reason of the patch,
which probably is a performance optimization (ie. not disabling twice IRQs).
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
--
Robert
prev parent reply other threads:[~2020-10-23 20:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 23:59 [PATCH 00/10] dmaengine: a bundle of cleanup on spin_lock_irqsave/irqrestore Barry Song
2020-10-15 23:59 ` [PATCH 01/10] dmaengine: ipu_idmac: remove redundant irqsave and restore in hardIRQ Barry Song
2020-10-15 23:59 ` [PATCH 02/10] dmaengine: k3-udma: remove redundant irqsave and irqrestore " Barry Song
2020-10-19 13:45 ` Peter Ujfalusi
2020-10-15 23:59 ` [PATCH 03/10] dmaengine: sf-pdma: " Barry Song
2020-10-15 23:59 ` [PATCH 04/10] dmaengine: tegra210-adma: " Barry Song
2020-10-19 10:31 ` Jon Hunter
2020-10-15 23:59 ` [PATCH 05/10] dmaengine: milbeaut-xdmac: " Barry Song
2020-10-15 23:59 ` [PATCH 06/10] dmaengine: k3dma: " Barry Song
2020-10-15 23:59 ` [PATCH 07/10] dmaengine: hisi_dma: " Barry Song
2020-10-26 1:23 ` Zhou Wang
2020-10-15 23:59 ` [PATCH 08/10] dmaengine: moxart-dma: " Barry Song
2020-10-15 23:59 ` [PATCH 09/10] dmaengine: ste_dma40: " Barry Song
2020-10-29 14:01 ` Linus Walleij
2020-10-29 20:58 ` Song Bao Hua (Barry Song)
2020-10-15 23:59 ` [PATCH 10/10] dmaengine: pxa_dma: " Barry Song
2020-10-23 20:16 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sga4wvd4.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=daniel@zonque.org \
--cc=dmaengine@vger.kernel.org \
--cc=haojian.zhuang@gmail.com \
--cc=song.bao.hua@hisilicon.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).