From: Sameer Pujar <spujar@nvidia.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: <jonathanh@nvidia.com>, <ldewangan@nvidia.com>,
<thierry.reding@gmail.com>, <dmaengine@vger.kernel.org>,
<linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v2] dmaengine: tegra210-adma: fix transfer failure
Date: Mon, 16 Sep 2019 13:05:29 +0530 [thread overview]
Message-ID: <8dd8a0f5-f6a4-46e7-f9ec-8aeecb13dcee@nvidia.com> (raw)
In-Reply-To: <20190808140842.GC12733@vkoul-mobl.Dlink>
Sorry for the delayed reply.
On 8/8/2019 7:38 PM, Vinod Koul wrote:
> On 12-07-19, 16:40, Sameer Pujar wrote:
>> >From Tegra186 onwards OUTSTANDING_REQUESTS field is added in channel
> ^^
> please remove the leading char from the para
Are you referring to extra char '>' here? I don't see this in my diff patch.
>
>> configuration register(bits 7:4) which defines the maximum number of reads
>> from the source and writes to the destination that may be outstanding at
>> any given point of time. This field must be programmed with a value
>> between 1 and 8. A value of 0 will prevent any transfers from happening.
>>
>> Thus added 'ch_pending_req' member in chip data structure and the same is
>> populated with maximum allowed pending requests. Since the field is not
>> applicable to Tegra210, mentioned bit fields are unused and hence the
>> member is initialized with 0. For Tegra186, by default program this field
>> with the maximum permitted value of 8.
>>
>> Fixes: 433de642a76c ("dmaengine: tegra210-adma: add support for Tegra186/Tegra194")
> Should this be tagged stable? Also some reviews from Tegra folks would
> be great
Ok, will tag this for stable.
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>> drivers/dma/tegra210-adma.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
>> index 2805853..5ab4e3a9 100644
>> --- a/drivers/dma/tegra210-adma.c
>> +++ b/drivers/dma/tegra210-adma.c
>> @@ -74,6 +74,8 @@
>> TEGRA186_ADMA_CH_FIFO_CTRL_TXSIZE(3) | \
>> TEGRA186_ADMA_CH_FIFO_CTRL_RXSIZE(3))
>>
>> +#define TEGRA186_DMA_MAX_PENDING_REQS 8
>> +
>> #define ADMA_CH_REG_FIELD_VAL(val, mask, shift) (((val) & mask) << shift)
>>
>> struct tegra_adma;
>> @@ -85,6 +87,7 @@ struct tegra_adma;
>> * @ch_req_tx_shift: Register offset for AHUB transmit channel select.
>> * @ch_req_rx_shift: Register offset for AHUB receive channel select.
>> * @ch_base_offset: Register offset of DMA channel registers.
>> + * @ch_pending_req: Outstaning DMA requests for a channel.
>> * @ch_fifo_ctrl: Default value for channel FIFO CTRL register.
>> * @ch_req_mask: Mask for Tx or Rx channel select.
>> * @ch_req_max: Maximum number of Tx or Rx channels available.
>> @@ -98,6 +101,7 @@ struct tegra_adma_chip_data {
>> unsigned int ch_req_tx_shift;
>> unsigned int ch_req_rx_shift;
>> unsigned int ch_base_offset;
>> + unsigned int ch_pending_req;
>> unsigned int ch_fifo_ctrl;
>> unsigned int ch_req_mask;
>> unsigned int ch_req_max;
>> @@ -602,6 +606,7 @@ static int tegra_adma_set_xfer_params(struct tegra_adma_chan *tdc,
>> ADMA_CH_CTRL_FLOWCTRL_EN;
>> ch_regs->config |= cdata->adma_get_burst_config(burst_size);
>> ch_regs->config |= ADMA_CH_CONFIG_WEIGHT_FOR_WRR(1);
>> + ch_regs->config |= cdata->ch_pending_req;
> so for tegra186 this will be 0, which per above would prevent any
> transfers?? What did i miss
For tegra186/tegra194 this will be non-zero and for tegra210 it will be 0.
The chip data reflects above.
>> ch_regs->fifo_ctrl = cdata->ch_fifo_ctrl;
>> ch_regs->tc = desc->period_len & ADMA_CH_TC_COUNT_MASK;
>>
>> @@ -786,6 +791,7 @@ static const struct tegra_adma_chip_data tegra210_chip_data = {
>> .ch_req_tx_shift = 28,
>> .ch_req_rx_shift = 24,
>> .ch_base_offset = 0,
>> + .ch_pending_req = 0,
>> .ch_fifo_ctrl = TEGRA210_FIFO_CTRL_DEFAULT,
>> .ch_req_mask = 0xf,
>> .ch_req_max = 10,
>> @@ -800,6 +806,7 @@ static const struct tegra_adma_chip_data tegra186_chip_data = {
>> .ch_req_tx_shift = 27,
>> .ch_req_rx_shift = 22,
>> .ch_base_offset = 0x10000,
>> + .ch_pending_req = (TEGRA186_DMA_MAX_PENDING_REQS << 4),
>> .ch_fifo_ctrl = TEGRA186_FIFO_CTRL_DEFAULT,
>> .ch_req_mask = 0x1f,
>> .ch_req_max = 20,
>> --
>> 2.7.4
next prev parent reply other threads:[~2019-09-16 7:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 11:10 [PATCH v2] dmaengine: tegra210-adma: fix transfer failure Sameer Pujar
2019-07-23 6:11 ` Sameer Pujar
2019-08-06 14:45 ` Sameer Pujar
2019-08-08 14:08 ` Vinod Koul
2019-09-16 7:35 ` Sameer Pujar [this message]
2019-08-19 17:40 ` Jon Hunter
2019-09-16 7:37 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dd8a0f5-f6a4-46e7-f9ec-8aeecb13dcee@nvidia.com \
--to=spujar@nvidia.com \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).